Title: [290195] trunk/Source/bmalloc
- Revision
- 290195
- Author
- ysuz...@apple.com
- Date
- 2022-02-18 19:56:45 -0800 (Fri, 18 Feb 2022)
Log Message
[libpas] Increase scavenger period from 100ms to 125ms in Darwin x64
https://bugs.webkit.org/show_bug.cgi?id=236873
Reviewed by Saam Barati.
Make x64 scavenger less aggressive while maintaining Membuster neutral
to make it less work.
* libpas/src/libpas/pas_config_prefix.h:
* libpas/src/libpas/pas_scavenger.c:
* libpas/src/libpas/pas_utils.h:
Modified Paths
Diff
Modified: trunk/Source/bmalloc/ChangeLog (290194 => 290195)
--- trunk/Source/bmalloc/ChangeLog 2022-02-19 03:53:08 UTC (rev 290194)
+++ trunk/Source/bmalloc/ChangeLog 2022-02-19 03:56:45 UTC (rev 290195)
@@ -1,3 +1,17 @@
+2022-02-18 Yusuke Suzuki <ysuz...@apple.com>
+
+ [libpas] Increase scavenger period from 100ms to 125ms in Darwin x64
+ https://bugs.webkit.org/show_bug.cgi?id=236873
+
+ Reviewed by Saam Barati.
+
+ Make x64 scavenger less aggressive while maintaining Membuster neutral
+ to make it less work.
+
+ * libpas/src/libpas/pas_config_prefix.h:
+ * libpas/src/libpas/pas_scavenger.c:
+ * libpas/src/libpas/pas_utils.h:
+
2022-02-18 Robert Jenner <jen...@apple.com>
Unreviewed, reverting r290149.
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h (290194 => 290195)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h 2022-02-19 03:53:08 UTC (rev 290194)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h 2022-02-19 03:56:45 UTC (rev 290195)
@@ -54,6 +54,18 @@
#define __PAS_ARM (!!__PAS_ARM64 || !!__PAS_ARM32)
+#if defined(__i386__) || defined(i386) || defined(_M_IX86) || defined(_X86_) || defined(__THW_INTEL)
+#define __PAS_X86 1
+#else
+#define __PAS_X86 0
+#endif
+
+#if defined(__x86_64__) || defined(_M_X64)
+#define __PAS_X86_64 1
+#else
+#define __PAS_X86_64 0
+#endif
+
#if defined(__riscv)
#define __PAS_RISCV 1
#else
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_scavenger.c (290194 => 290195)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_scavenger.c 2022-02-19 03:53:08 UTC (rev 290194)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_scavenger.c 2022-02-19 03:56:45 UTC (rev 290195)
@@ -61,7 +61,11 @@
double pas_scavenger_period_in_milliseconds = 10.;
uint64_t pas_scavenger_max_epoch_delta = 10ll * 1000ll * 1000ll;
#else
+#if PAS_OS(DARWIN) && PAS_X86_64
+double pas_scavenger_period_in_milliseconds = 125.;
+#else
double pas_scavenger_period_in_milliseconds = 100.;
+#endif
uint64_t pas_scavenger_max_epoch_delta = 300ll * 1000ll * 1000ll;
#endif
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h (290194 => 290195)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h 2022-02-19 03:53:08 UTC (rev 290194)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h 2022-02-19 03:56:45 UTC (rev 290195)
@@ -84,6 +84,9 @@
#define PAS_ARM __PAS_ARM
+#define PAS_X86 __PAS_X86
+#define PAS_X86_64 __PAS_X86_64
+
#define PAS_RISCV __PAS_RISCV
#if PAS_ARM64 && !PAS_ARM64E && !PAS_OS(MAC) && !defined(__ARM_FEATURE_ATOMICS)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
