Title: [290425] trunk/LayoutTests
Revision
290425
Author
you...@apple.com
Date
2022-02-24 04:29:30 -0800 (Thu, 24 Feb 2022)

Log Message

webrtc/video-replace-muted-track.html is unnecessary long to run
https://bugs.webkit.org/show_bug.cgi?id=237086

Reviewed by Peng Liu.

* platform/mac/TestExpectations: Unflake test since it is no longer flaky in bots.
* webrtc/routines.js:
We were waiting for 360 iterations to validate no black frame is found in webrtc/routines.js.
This makes it last around 20 seconds.
Decrease the number of iterations to 40, around 2 seconds by decrementing counter from provided value
instead of incrementing value up to 400.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (290424 => 290425)


--- trunk/LayoutTests/ChangeLog	2022-02-24 12:17:15 UTC (rev 290424)
+++ trunk/LayoutTests/ChangeLog	2022-02-24 12:29:30 UTC (rev 290425)
@@ -1,3 +1,17 @@
+2022-02-24  Youenn Fablet  <you...@apple.com>
+
+        webrtc/video-replace-muted-track.html is unnecessary long to run
+        https://bugs.webkit.org/show_bug.cgi?id=237086
+
+        Reviewed by Peng Liu.
+
+        * platform/mac/TestExpectations: Unflake test since it is no longer flaky in bots.
+        * webrtc/routines.js:
+        We were waiting for 360 iterations to validate no black frame is found in webrtc/routines.js.
+        This makes it last around 20 seconds.
+        Decrease the number of iterations to 40, around 2 seconds by decrementing counter from provided value
+        instead of incrementing value up to 400.
+
 2022-02-24  Alejandro G. Castro  <a...@igalia.com>
 
         Unreviewed test gardening.

Modified: trunk/LayoutTests/platform/mac/TestExpectations (290424 => 290425)


--- trunk/LayoutTests/platform/mac/TestExpectations	2022-02-24 12:17:15 UTC (rev 290424)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2022-02-24 12:29:30 UTC (rev 290425)
@@ -2193,8 +2193,6 @@
 # See https://webkit.org/b/120081 for why this is one expectation.
 webkit.org/b/225523 webrtc/direction-change.html [ Pass Timeout Failure ]
 
-webkit.org/b/22525 webrtc/video-replace-muted-track.html [ Pass Failure ]
-
 webkit.org/b/225528 [ arm64 ] http/wpt/fetch/fetch-response-body-stop-in-worker.html [ Pass Crash ]
 
 webkit.org/b/225258 [ arm64 ] js/dom/Promise-reject-large-string.html [ Pass Failure ]

Modified: trunk/LayoutTests/webrtc/routines.js (290424 => 290425)


--- trunk/LayoutTests/webrtc/routines.js	2022-02-24 12:17:15 UTC (rev 290424)
+++ trunk/LayoutTests/webrtc/routines.js	2022-02-24 12:29:30 UTC (rev 290425)
@@ -207,8 +207,8 @@
         return Promise.resolve();
 
     if (counter === undefined)
-        counter = 0;
-    if (counter > 400) {
+        counter = 400;
+    if (counter === 0) {
         if (!errorMessage)
             errorMessage = "checkVideoBlack timed out expecting " + expected;
         return Promise.reject(errorMessage);
@@ -215,7 +215,7 @@
     }
 
     await waitFor(50);
-    return checkVideoBlack(expected, canvas, video, errorMessage, ++counter);
+    return checkVideoBlack(expected, canvas, video, errorMessage, --counter);
 }
 
 function setCodec(sdp, codec)
@@ -427,4 +427,4 @@
     }
     if (debuge)
         debuge.removeChild(canvas);
-}
\ No newline at end of file
+}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to