Title: [290652] trunk/Tools
- Revision
- 290652
- Author
- j_pas...@apple.com
- Date
- 2022-03-01 09:40:35 -0800 (Tue, 01 Mar 2022)
Log Message
REGRESSION(r290539-r290538): [ iOS ] 3 TestWebKitAPI.WebAuthenticationPanel.* tests are constantly failing/crashing.
https://bugs.webkit.org/show_bug.cgi?id=237285
rdar://problem/89579460
Reviewed by Brent Fulgham.
Remove obsolete API test and ensure another has clean state.
* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (290651 => 290652)
--- trunk/Tools/ChangeLog 2022-03-01 17:17:45 UTC (rev 290651)
+++ trunk/Tools/ChangeLog 2022-03-01 17:40:35 UTC (rev 290652)
@@ -1,3 +1,16 @@
+2022-03-01 J Pascoe <j_pas...@apple.com>
+
+ REGRESSION(r290539-r290538): [ iOS ] 3 TestWebKitAPI.WebAuthenticationPanel.* tests are constantly failing/crashing.
+ https://bugs.webkit.org/show_bug.cgi?id=237285
+ rdar://problem/89579460
+
+ Reviewed by Brent Fulgham.
+
+ Remove obsolete API test and ensure another has clean state.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
+ (TestWebKitAPI::TEST):
+
2022-03-01 Commit Queue <commit-qu...@webkit.org>
Unreviewed, reverting r290325.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm (290651 => 290652)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm 2022-03-01 17:17:45 UTC (rev 290651)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm 2022-03-01 17:40:35 UTC (rev 290652)
@@ -1384,6 +1384,9 @@
TEST(WebAuthenticationPanel, LANoCredential)
{
reset();
+ // In case this wasn't cleaned up by another test.
+ cleanUpKeychain("");
+
RetainPtr<NSURL> testURL = [[NSBundle mainBundle] URLForResource:@"web-authentication-get-assertion-la" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
auto *configuration = [WKWebViewConfiguration _test_configurationWithTestPlugInClassName:@"WebProcessPlugInWithInternals" configureJSCForTesting:YES];
@@ -1471,33 +1474,6 @@
[webView waitForMessage:@"This request has been cancelled by the user."];
}
-TEST(WebAuthenticationPanel, LAMakeCredentialRollBackCredential)
-{
- reset();
- RetainPtr<NSURL> testURL = [[NSBundle mainBundle] URLForResource:@"web-authentication-make-credential-la-no-attestation" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
-
- auto *configuration = [WKWebViewConfiguration _test_configurationWithTestPlugInClassName:@"WebProcessPlugInWithInternals" configureJSCForTesting:YES];
- [[configuration preferences] _setEnabled:NO forExperimentalFeature:webAuthenticationModernExperimentalFeature()];
-
- auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSZeroRect configuration:configuration]);
- auto delegate = adoptNS([[TestWebAuthenticationPanelUIDelegate alloc] init]);
- [webView setUIDelegate:delegate.get()];
- [webView focus];
-
- localAuthenticatorPolicy = _WKLocalAuthenticatorPolicyAllow;
- [webView loadRequest:[NSURLRequest requestWithURL:testURL.get()]];
- [webView waitForMessage:@"Couldn't attest: The operation couldn't complete."];
-
- NSDictionary *query = @{
- (id)kSecClass: (id)kSecClassKey,
- (id)kSecAttrKeyClass: (id)kSecAttrKeyClassPrivate,
- (id)kSecAttrLabel: @"",
- (id)kSecUseDataProtectionKeychain: @YES
- };
- OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query, nullptr);
- EXPECT_EQ(status, errSecItemNotFound);
-}
-
#if PLATFORM(MAC)
TEST(WebAuthenticationPanel, LAGetAssertion)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
