Title: [290715] trunk/Source/WebCore
- Revision
- 290715
- Author
- andresg...@apple.com
- Date
- 2022-03-01 18:03:52 -0800 (Tue, 01 Mar 2022)
Log Message
Unnecessary copy of Vector of children IDs in AXIsolatedTree::updateChildren.
https://bugs.webkit.org/show_bug.cgi?id=237338
<rdar://problem/89633856>
Reviewed by Chris Fleizach.
Changed the copy of this Vector to a move.
* accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildren):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (290714 => 290715)
--- trunk/Source/WebCore/ChangeLog 2022-03-02 01:53:20 UTC (rev 290714)
+++ trunk/Source/WebCore/ChangeLog 2022-03-02 02:03:52 UTC (rev 290715)
@@ -1,3 +1,16 @@
+2022-03-01 Andres Gonzalez <andresg...@apple.com>
+
+ Unnecessary copy of Vector of children IDs in AXIsolatedTree::updateChildren.
+ https://bugs.webkit.org/show_bug.cgi?id=237338
+ <rdar://problem/89633856>
+
+ Reviewed by Chris Fleizach.
+
+ Changed the copy of this Vector to a move.
+
+ * accessibility/isolatedtree/AXIsolatedTree.cpp:
+ (WebCore::AXIsolatedTree::updateChildren):
+
2022-03-01 Alan Bujtas <za...@apple.com>
REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wrong in Safari, ok in Chrome and Firefox
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp (290714 => 290715)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp 2022-03-02 01:53:20 UTC (rev 290714)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp 2022-03-02 02:03:52 UTC (rev 290715)
@@ -403,7 +403,7 @@
collectNodeChangesForSubtree(*newChildren[i], axAncestor->objectID(), true, changes, &idsBeingChanged);
}
}
- m_nodeMap.set(axAncestor->objectID(), ParentChildrenIDs { oldIDs.parentID, newChildrenIDs });
+ m_nodeMap.set(axAncestor->objectID(), ParentChildrenIDs { oldIDs.parentID, WTFMove(newChildrenIDs) });
// What is left in oldChildrenIDs are the IDs that are no longer children of axAncestor.
// Thus, remove them from m_nodeMap and queue them to be removed from the tree.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
