Title: [290929] branches/safari-613-branch
- Revision
- 290929
- Author
- [email protected]
- Date
- 2022-03-07 14:09:47 -0800 (Mon, 07 Mar 2022)
Log Message
Cherry-pick r290197. rdar://problem/88818132
Stop propagating inertness through iframes in Node::deprecatedIsInert()
https://bugs.webkit.org/show_bug.cgi?id=236512
Reviewed by Chris Dumez.
This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
before this bug.
LayoutTests/imported/w3c:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
Source/WebCore:
Test: web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames.html
* dom/Node.cpp:
(WebCore::Node::deprecatedIsInert const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog (290928 => 290929)
--- branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog 2022-03-07 22:09:43 UTC (rev 290928)
+++ branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog 2022-03-07 22:09:47 UTC (rev 290929)
@@ -1,5 +1,42 @@
2022-03-07 Russell Epstein <[email protected]>
+ Cherry-pick r290197. rdar://problem/88818132
+
+ Stop propagating inertness through iframes in Node::deprecatedIsInert()
+ https://bugs.webkit.org/show_bug.cgi?id=236512
+
+ Reviewed by Chris Dumez.
+
+ This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
+ before this bug.
+
+ LayoutTests/imported/w3c:
+
+ * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
+
+ Source/WebCore:
+
+ Test: web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames.html
+
+ * dom/Node.cpp:
+ (WebCore::Node::deprecatedIsInert const):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-02-18 Tim Nguyen <[email protected]>
+
+ Stop propagating inertness through iframes in Node::deprecatedIsInert()
+ https://bugs.webkit.org/show_bug.cgi?id=236512
+
+ Reviewed by Chris Dumez.
+
+ This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
+ before this bug.
+
+ * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
+
+2022-03-07 Russell Epstein <[email protected]>
+
Cherry-pick r290164. rdar://problem/89162532
Re-import inert and <dialog> WPT
Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (290928 => 290929)
--- branches/safari-613-branch/Source/WebCore/ChangeLog 2022-03-07 22:09:43 UTC (rev 290928)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog 2022-03-07 22:09:47 UTC (rev 290929)
@@ -1,5 +1,45 @@
2022-03-07 Russell Epstein <[email protected]>
+ Cherry-pick r290197. rdar://problem/88818132
+
+ Stop propagating inertness through iframes in Node::deprecatedIsInert()
+ https://bugs.webkit.org/show_bug.cgi?id=236512
+
+ Reviewed by Chris Dumez.
+
+ This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
+ before this bug.
+
+ LayoutTests/imported/w3c:
+
+ * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
+
+ Source/WebCore:
+
+ Test: web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames.html
+
+ * dom/Node.cpp:
+ (WebCore::Node::deprecatedIsInert const):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-02-18 Tim Nguyen <[email protected]>
+
+ Stop propagating inertness through iframes in Node::deprecatedIsInert()
+ https://bugs.webkit.org/show_bug.cgi?id=236512
+
+ Reviewed by Chris Dumez.
+
+ This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
+ before this bug.
+
+ Test: web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames.html
+
+ * dom/Node.cpp:
+ (WebCore::Node::deprecatedIsInert const):
+
+2022-03-07 Russell Epstein <[email protected]>
+
Cherry-pick r289859. rdar://problem/88491516
Skip positioned objects and line break boxes as they have no affect on width
Modified: branches/safari-613-branch/Source/WebCore/dom/Node.cpp (290928 => 290929)
--- branches/safari-613-branch/Source/WebCore/dom/Node.cpp 2022-03-07 22:09:43 UTC (rev 290928)
+++ branches/safari-613-branch/Source/WebCore/dom/Node.cpp 2022-03-07 22:09:47 UTC (rev 290929)
@@ -2641,10 +2641,7 @@
}
}
- if (!document().frame() || !document().frame()->ownerElement())
- return false;
-
- return document().frame()->ownerElement()->deprecatedIsInert();
+ return false;
}
template<> ContainerNode* parent<Tree>(const Node& node)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
