- Revision
- 107450
- Author
- a...@chromium.org
- Date
- 2012-02-10 15:49:13 -0800 (Fri, 10 Feb 2012)
Log Message
Don't lowercase ping URLs.
Previously, ping URLs would be lowercased when splitting them apart.
URLs are not, however, case-insensitive.
https://bugs.webkit.org/show_bug.cgi?id=78371
Reviewed by Tony Chang.
Source/WebCore:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::sendPings): Don't lowercase URL.
LayoutTests:
* http/tests/navigation/image-load-in-unload-handler.html: update to new URL
* http/tests/navigation/ping-cookie.html:
* http/tests/navigation/ping-cross-origin.html:
* http/tests/navigation/ping-same-origin.html:
* http/tests/navigation/resources/save-Ping.php: Renamed from LayoutTests/http/tests/navigation/resources/save-ping.php.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (107449 => 107450)
--- trunk/LayoutTests/ChangeLog 2012-02-10 23:38:51 UTC (rev 107449)
+++ trunk/LayoutTests/ChangeLog 2012-02-10 23:49:13 UTC (rev 107450)
@@ -1,3 +1,20 @@
+2012-02-10 Adam Langley <a...@chromium.org>
+
+ Don't lowercase ping URLs.
+
+ Previously, ping URLs would be lowercased when splitting them apart.
+ URLs are not, however, case-insensitive.
+
+ https://bugs.webkit.org/show_bug.cgi?id=78371
+
+ Reviewed by Tony Chang.
+
+ * http/tests/navigation/image-load-in-unload-handler.html: update to new URL
+ * http/tests/navigation/ping-cookie.html:
+ * http/tests/navigation/ping-cross-origin.html:
+ * http/tests/navigation/ping-same-origin.html:
+ * http/tests/navigation/resources/save-Ping.php: Renamed from LayoutTests/http/tests/navigation/resources/save-ping.php.
+
2012-02-10 Ami Fischman <fisch...@chromium.org>
media/video-empty-source.html needs a rebaseline for chromium
Modified: trunk/LayoutTests/http/tests/navigation/image-load-in-unload-handler.html (107449 => 107450)
--- trunk/LayoutTests/http/tests/navigation/image-load-in-unload-handler.html 2012-02-10 23:38:51 UTC (rev 107449)
+++ trunk/LayoutTests/http/tests/navigation/image-load-in-unload-handler.html 2012-02-10 23:49:13 UTC (rev 107450)
@@ -24,7 +24,7 @@
function ping() {
var img = new Image(1, 1);
- img.src = ""
+ img.src = ""
}
</script>
Modified: trunk/LayoutTests/http/tests/navigation/ping-cookie.html (107449 => 107450)
--- trunk/LayoutTests/http/tests/navigation/ping-cookie.html 2012-02-10 23:38:51 UTC (rev 107449)
+++ trunk/LayoutTests/http/tests/navigation/ping-cookie.html 2012-02-10 23:49:13 UTC (rev 107450)
@@ -42,5 +42,5 @@
</head>
<body _onload_="test();">
<img src="" _onload_="test();" _onerror_="test();"></img>
-<a id="a" href="" ping="resources/save-ping.php">Navigate and send ping</a>
+<a id="a" href="" ping="resources/save-Ping.php">Navigate and send ping</a>
</body></html>
Modified: trunk/LayoutTests/http/tests/navigation/ping-cross-origin.html (107449 => 107450)
--- trunk/LayoutTests/http/tests/navigation/ping-cross-origin.html 2012-02-10 23:38:51 UTC (rev 107449)
+++ trunk/LayoutTests/http/tests/navigation/ping-cross-origin.html 2012-02-10 23:49:13 UTC (rev 107450)
@@ -27,5 +27,5 @@
</head>
<body _onload_="test();">
<img src="" _onload_="test();" _onerror_="test();"></img>
-<a id="a" href="" ping="http://localhost:8000/navigation/resources/save-ping.php">Navigate and send ping</a>
+<a id="a" href="" ping="http://localhost:8000/navigation/resources/save-Ping.php">Navigate and send ping</a>
</body></html>
Modified: trunk/LayoutTests/http/tests/navigation/ping-same-origin.html (107449 => 107450)
--- trunk/LayoutTests/http/tests/navigation/ping-same-origin.html 2012-02-10 23:38:51 UTC (rev 107449)
+++ trunk/LayoutTests/http/tests/navigation/ping-same-origin.html 2012-02-10 23:49:13 UTC (rev 107450)
@@ -27,5 +27,5 @@
</head>
<body _onload_="test();">
<img src="" _onload_="test();" _onerror_="test();"></img>
-<a id="a" href="" ping="resources/save-ping.php">Navigate and send ping</a>
+<a id="a" href="" ping="resources/save-Ping.php">Navigate and send ping</a>
</body></html>
Copied: trunk/LayoutTests/http/tests/navigation/resources/save-Ping.php (from rev 107449, trunk/LayoutTests/http/tests/navigation/resources/save-ping.php) (0 => 107450)
--- trunk/LayoutTests/http/tests/navigation/resources/save-Ping.php (rev 0)
+++ trunk/LayoutTests/http/tests/navigation/resources/save-Ping.php 2012-02-10 23:49:13 UTC (rev 107450)
@@ -0,0 +1,13 @@
+<?php
+$pingFile = fopen("ping.txt.tmp", 'w');
+$httpHeaders = $_SERVER;
+ksort($httpHeaders, SORT_STRING);
+foreach ($httpHeaders as $name => $value) {
+ if ($name === "CONTENT_TYPE" || $name === "HTTP_REFERER" || $name === "HTTP_PING_TO" || $name === "HTTP_PING_FROM" || $name === "REQUEST_METHOD" || $name === "HTTP_COOKIE")
+ fwrite($pingFile, "$name: $value\n");
+}
+fclose($pingFile);
+rename("ping.txt.tmp", "ping.txt");
+foreach ($_COOKIE as $name => $value)
+ setcookie($name, "deleted", time() - 60, "/");
+?>
Deleted: trunk/LayoutTests/http/tests/navigation/resources/save-ping.php (107449 => 107450)
--- trunk/LayoutTests/http/tests/navigation/resources/save-ping.php 2012-02-10 23:38:51 UTC (rev 107449)
+++ trunk/LayoutTests/http/tests/navigation/resources/save-ping.php 2012-02-10 23:49:13 UTC (rev 107450)
@@ -1,13 +0,0 @@
-<?php
-$pingFile = fopen("ping.txt.tmp", 'w');
-$httpHeaders = $_SERVER;
-ksort($httpHeaders, SORT_STRING);
-foreach ($httpHeaders as $name => $value) {
- if ($name === "CONTENT_TYPE" || $name === "HTTP_REFERER" || $name === "HTTP_PING_TO" || $name === "HTTP_PING_FROM" || $name === "REQUEST_METHOD" || $name === "HTTP_COOKIE")
- fwrite($pingFile, "$name: $value\n");
-}
-fclose($pingFile);
-rename("ping.txt.tmp", "ping.txt");
-foreach ($_COOKIE as $name => $value)
- setcookie($name, "deleted", time() - 60, "/");
-?>
Modified: trunk/Source/WebCore/ChangeLog (107449 => 107450)
--- trunk/Source/WebCore/ChangeLog 2012-02-10 23:38:51 UTC (rev 107449)
+++ trunk/Source/WebCore/ChangeLog 2012-02-10 23:49:13 UTC (rev 107450)
@@ -1,3 +1,17 @@
+2012-02-10 Adam Langley <a...@chromium.org>
+
+ Don't lowercase ping URLs.
+
+ Previously, ping URLs would be lowercased when splitting them apart.
+ URLs are not, however, case-insensitive.
+
+ https://bugs.webkit.org/show_bug.cgi?id=78371
+
+ Reviewed by Tony Chang.
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::sendPings): Don't lowercase URL.
+
2012-02-10 Ojan Vafai <o...@chromium.org>
flex-pack:center and flex-item-align:center should do true centering
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (107449 => 107450)
--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2012-02-10 23:38:51 UTC (rev 107449)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2012-02-10 23:49:13 UTC (rev 107450)
@@ -489,7 +489,7 @@
if (!hasAttribute(pingAttr) || !document()->settings()->hyperlinkAuditingEnabled())
return;
- SpaceSplitString pingURLs(getAttribute(pingAttr), true);
+ SpaceSplitString pingURLs(getAttribute(pingAttr), false);
for (unsigned i = 0; i < pingURLs.size(); i++)
PingLoader::sendPing(document()->frame(), document()->completeURL(pingURLs[i]), destinationURL);
}
