Title: [291632] branches/safari-613-branch/Source/WebKit
- Revision
- 291632
- Author
- alanc...@apple.com
- Date
- 2022-03-22 10:54:25 -0700 (Tue, 22 Mar 2022)
Log Message
Cherry-pick r290328. rdar://problem/88567612
Fix GPUP WebGL generator script wrt uninitialised sized span
https://bugs.webkit.org/show_bug.cgi?id=235889
<rdar://problem/88567612>
Reviewed by Chris Dumez.
Even though we check if the synchronous message was received successfully before using it,
if we didn't check then we might have a problem with pointing to uninitialized memory, which we then wouldn't use for anything.
To fix this hypothetical problem, I start out by pointing to initialized memory.
* WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
(WebKit::RemoteGraphicsContextGLProxy::getShaderPrecisionFormat):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (291631 => 291632)
--- branches/safari-613-branch/Source/WebKit/ChangeLog 2022-03-22 17:54:21 UTC (rev 291631)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog 2022-03-22 17:54:25 UTC (rev 291632)
@@ -1,5 +1,41 @@
2022-03-21 Alan Coon <alanc...@apple.com>
+ Cherry-pick r290328. rdar://problem/88567612
+
+ Fix GPUP WebGL generator script wrt uninitialised sized span
+ https://bugs.webkit.org/show_bug.cgi?id=235889
+ <rdar://problem/88567612>
+
+ Reviewed by Chris Dumez.
+
+ Even though we check if the synchronous message was received successfully before using it,
+ if we didn't check then we might have a problem with pointing to uninitialized memory, which we then wouldn't use for anything.
+ To fix this hypothetical problem, I start out by pointing to initialized memory.
+
+ * WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
+ (WebKit::RemoteGraphicsContextGLProxy::getShaderPrecisionFormat):
+
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-02-22 Alex Christensen <achristen...@webkit.org>
+
+ Fix GPUP WebGL generator script wrt uninitialised sized span
+ https://bugs.webkit.org/show_bug.cgi?id=235889
+ <rdar://problem/88567612>
+
+ Reviewed by Chris Dumez.
+
+ Even though we check if the synchronous message was received successfully before using it,
+ if we didn't check then we might have a problem with pointing to uninitialized memory, which we then wouldn't use for anything.
+ To fix this hypothetical problem, I start out by pointing to initialized memory.
+
+ * WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
+ (WebKit::RemoteGraphicsContextGLProxy::getShaderPrecisionFormat):
+
+2022-03-21 Alan Coon <alanc...@apple.com>
+
Cherry-pick r288662. rdar://problem/89582442
[WP] Avoid calling IOSurfaceAlignProperty
Modified: branches/safari-613-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp (291631 => 291632)
--- branches/safari-613-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp 2022-03-22 17:54:21 UTC (rev 291631)
+++ branches/safari-613-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp 2022-03-22 17:54:25 UTC (rev 291632)
@@ -686,7 +686,8 @@
void RemoteGraphicsContextGLProxy::getShaderPrecisionFormat(GCGLenum shaderType, GCGLenum precisionType, GCGLSpan<GCGLint, 2> range, GCGLint* precision)
{
- IPC::ArrayReference<int32_t, 2> rangeReply { { } };
+ constexpr std::array<int32_t, 2> emptyRangeReply { 0, 0 };
+ IPC::ArrayReference<int32_t, 2> rangeReply { emptyRangeReply };
int32_t precisionReply = { };
if (!isContextLost()) {
auto sendResult = sendSync(Messages::RemoteGraphicsContextGL::GetShaderPrecisionFormat(shaderType, precisionType), Messages::RemoteGraphicsContextGL::GetShaderPrecisionFormat::Reply(rangeReply, precisionReply));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
