Title: [291655] branches/safari-613-branch/Source/WebKit
Revision
291655
Author
alanc...@apple.com
Date
2022-03-22 10:55:59 -0700 (Tue, 22 Mar 2022)

Log Message

Cherry-pick r291006. rdar://problem/85361911

    The accessibility library should be soft linked optionally
    https://bugs.webkit.org/show_bug.cgi?id=236513

    Reviewed by Geoffrey Garen.

    The accessibility library should be soft linked optionally, since it is not always present.

    * Shared/Cocoa/AuxiliaryProcessCocoa.mm:
    (WebKit::handleAXPreferenceChange):
    (WebKit::AuxiliaryProcess::handlePreferenceChange):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (291654 => 291655)


--- branches/safari-613-branch/Source/WebKit/ChangeLog	2022-03-22 17:55:56 UTC (rev 291654)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog	2022-03-22 17:55:59 UTC (rev 291655)
@@ -1,5 +1,36 @@
 2022-03-21  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r291006. rdar://problem/85361911
+
+    The accessibility library should be soft linked optionally
+    https://bugs.webkit.org/show_bug.cgi?id=236513
+    
+    Reviewed by Geoffrey Garen.
+    
+    The accessibility library should be soft linked optionally, since it is not always present.
+    
+    * Shared/Cocoa/AuxiliaryProcessCocoa.mm:
+    (WebKit::handleAXPreferenceChange):
+    (WebKit::AuxiliaryProcess::handlePreferenceChange):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-03-08  Per Arne Vollan  <pvol...@apple.com>
+
+            The accessibility library should be soft linked optionally
+            https://bugs.webkit.org/show_bug.cgi?id=236513
+
+            Reviewed by Geoffrey Garen.
+
+            The accessibility library should be soft linked optionally, since it is not always present.
+
+            * Shared/Cocoa/AuxiliaryProcessCocoa.mm:
+            (WebKit::handleAXPreferenceChange):
+            (WebKit::AuxiliaryProcess::handlePreferenceChange):
+
+2022-03-21  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r290969. rdar://problem/89638872
 
     Preconnecting after process swap is a page load time improvement on some devices

Modified: branches/safari-613-branch/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm (291654 => 291655)


--- branches/safari-613-branch/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm	2022-03-22 17:55:56 UTC (rev 291654)
+++ branches/safari-613-branch/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm	2022-03-22 17:55:59 UTC (rev 291655)
@@ -46,7 +46,7 @@
 #endif
 
 #if HAVE(UPDATE_WEB_ACCESSIBILITY_SETTINGS) && ENABLE(CFPREFS_DIRECT_MODE)
-SOFT_LINK_LIBRARY(libAccessibility)
+SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
 SOFT_LINK_OPTIONAL(libAccessibility, _AXSUpdateWebAccessibilitySettings, void, (), ());
 #endif
 
@@ -197,8 +197,13 @@
 }
 #endif
 
-void AuxiliaryProcess::handlePreferenceChange(const String& domain, const String& key, id value)
+static void handleAXPreferenceChange(const String& domain, const String& key, id value)
 {
+#if HAVE(UPDATE_WEB_ACCESSIBILITY_SETTINGS)
+    if (!liblibAccessibility())
+        return;
+#endif
+
     if (domain == String(kAXSAccessibilityPreferenceDomain)) {
 #if HAVE(UPDATE_WEB_ACCESSIBILITY_SETTINGS)
         if (_AXSUpdateWebAccessibilitySettingsPtr())
@@ -212,7 +217,11 @@
             _AXSSetDarkenSystemColors([(NSNumber *)value boolValue]);
 #endif
     }
+}
 
+void AuxiliaryProcess::handlePreferenceChange(const String& domain, const String& key, id value)
+{
+    handleAXPreferenceChange(domain, key, value);
     dispatchSimulatedNotificationsForPreferenceChange(key);
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to