Title: [291823] trunk/Source/WebKit
- Revision
- 291823
- Author
- pan...@apple.com
- Date
- 2022-03-24 16:23:53 -0700 (Thu, 24 Mar 2022)
Log Message
REGRESSION(STP142): "A _javascript_ exception occured: Can't find variable: utils" from SafariDriver
https://bugs.webkit.org/show_bug.cgi?id=238335
Reviewed by Devin Rousso.
Following r289467, we can't just copy the WebDriver atom scripts to the build products, since they now need to
have `utils.js` in any script that uses the `utils` namespace. The `WebKit.framework` copy of these scripts are
later used while building safaridriver, so they need to include the scripts as well.
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (291822 => 291823)
--- trunk/Source/WebKit/ChangeLog 2022-03-24 23:22:51 UTC (rev 291822)
+++ trunk/Source/WebKit/ChangeLog 2022-03-24 23:23:53 UTC (rev 291823)
@@ -1,3 +1,16 @@
+2022-03-24 Patrick Angle <pan...@apple.com>
+
+ REGRESSION(STP142): "A _javascript_ exception occured: Can't find variable: utils" from SafariDriver
+ https://bugs.webkit.org/show_bug.cgi?id=238335
+
+ Reviewed by Devin Rousso.
+
+ Following r289467, we can't just copy the WebDriver atom scripts to the build products, since they now need to
+ have `utils.js` in any script that uses the `utils` namespace. The `WebKit.framework` copy of these scripts are
+ later used while building safaridriver, so they need to include the scripts as well.
+
+ * WebKit.xcodeproj/project.pbxproj:
+
2022-03-24 Per Arne Vollan <pvol...@apple.com>
REGRESSION(r286590): Links with URL schemes are not clickable in Mail
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (291822 => 291823)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-03-24 23:22:51 UTC (rev 291822)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-03-24 23:23:53 UTC (rev 291823)
@@ -16685,7 +16685,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "DST_DIR=\"$TARGET_BUILD_DIR/$PRIVATE_HEADERS_FOLDER_PATH/atoms\"\nmkdir -p \"$DST_DIR\"\n\nfor ((i = 0; i < ${SCRIPT_INPUT_FILE_COUNT}; ++i)); do\n eval WEBDRIVER_ATOM=\\${SCRIPT_INPUT_FILE_${i}}\n ditto \"${WEBDRIVER_ATOM}\" \"${DST_DIR}/${WEBDRIVER_ATOM##*/}\"\ndone\n";
+ shellScript = "DST_DIR=\"$TARGET_BUILD_DIR/$PRIVATE_HEADERS_FOLDER_PATH/atoms\"\nmkdir -p \"$DST_DIR\"\n\nfor ((i = 0; i < ${SCRIPT_INPUT_FILE_COUNT}; ++i)); do\n eval WEBDRIVER_ATOM=\\${SCRIPT_INPUT_FILE_${i}}\n python3 ${SRCROOT}/Scripts/generate-automation-atom.py \"${WEBDRIVER_ATOM}\" \"${DST_DIR}/${WEBDRIVER_ATOM##*/}\"\ndone\n";
};
A55DEAA61670402E003DB841 /* Check For Inappropriate Macros in External Headers */ = {
isa = PBXShellScriptBuildPhase;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
