Title: [291929] trunk/Source/WebKit
- Revision
- 291929
- Author
- simon.fra...@apple.com
- Date
- 2022-03-25 19:03:26 -0700 (Fri, 25 Mar 2022)
Log Message
Temporarily disable assertion in MessageReceiveQueueMap::addImpl()
https://bugs.webkit.org/show_bug.cgi?id=238397
Reviewed by Wenson Hsieh.
Enabling DOM Rendering in the GPU Process has exposed an issue (webkit.org/b/237674, webkit.org/b/238391).
Temporarily convert this assertion to logging to reduce test failures.
* Platform/IPC/MessageReceiveQueueMap.cpp:
(IPC::MessageReceiveQueueMap::addImpl):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (291928 => 291929)
--- trunk/Source/WebKit/ChangeLog 2022-03-26 01:58:16 UTC (rev 291928)
+++ trunk/Source/WebKit/ChangeLog 2022-03-26 02:03:26 UTC (rev 291929)
@@ -1,3 +1,16 @@
+2022-03-25 Simon Fraser <simon.fra...@apple.com>
+
+ Temporarily disable assertion in MessageReceiveQueueMap::addImpl()
+ https://bugs.webkit.org/show_bug.cgi?id=238397
+
+ Reviewed by Wenson Hsieh.
+
+ Enabling DOM Rendering in the GPU Process has exposed an issue (webkit.org/b/237674, webkit.org/b/238391).
+ Temporarily convert this assertion to logging to reduce test failures.
+
+ * Platform/IPC/MessageReceiveQueueMap.cpp:
+ (IPC::MessageReceiveQueueMap::addImpl):
+
2022-03-25 Sihui Liu <sihui_...@apple.com>
Disable custom storage paths for IndexedDB and LocalStorage by default
Modified: trunk/Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp (291928 => 291929)
--- trunk/Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp 2022-03-26 01:58:16 UTC (rev 291928)
+++ trunk/Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp 2022-03-26 02:03:26 UTC (rev 291929)
@@ -25,6 +25,7 @@
#include "config.h"
#include "MessageReceiveQueueMap.h"
+#include <wtf/text/TextStream.h>
namespace IPC {
@@ -31,7 +32,10 @@
void MessageReceiveQueueMap::addImpl(StoreType&& queue, ReceiverName receiverName, uint64_t destinationID)
{
auto key = std::make_pair(static_cast<uint8_t>(receiverName), destinationID);
- ASSERT(!m_queues.contains(key));
+ if (m_queues.contains(key)) {
+ // FIXME: This should be an assertion. See webkit.org/b/237674 and webkit.org/b/238391.
+ ALWAYS_LOG_WITH_STREAM(stream << "MessageReceiveQueueMap::addImpl - adding duplicate receiver " << static_cast<uint8_t>(receiverName) << " for destination " << destinationID);
+ }
m_queues.add(key, WTFMove(queue));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
