Title: [291969] trunk/Source/WebCore
Revision
291969
Author
you...@apple.com
Date
2022-03-28 09:43:04 -0700 (Mon, 28 Mar 2022)

Log Message

ImageTransferSessionVT::setSize should properly create its buffer pool
https://bugs.webkit.org/show_bug.cgi?id=238455

Reviewed by Eric Carlson.

Covered by existing tests.

* platform/graphics/cv/ImageTransferSessionVT.mm:
(WebCore::ImageTransferSessionVT::setSize):
We check the Expected, then move the RetainPtr if available.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (291968 => 291969)


--- trunk/Source/WebCore/ChangeLog	2022-03-28 16:28:57 UTC (rev 291968)
+++ trunk/Source/WebCore/ChangeLog	2022-03-28 16:43:04 UTC (rev 291969)
@@ -1,3 +1,16 @@
+2022-03-28  Youenn Fablet  <you...@apple.com>
+
+        ImageTransferSessionVT::setSize should properly create its buffer pool
+        https://bugs.webkit.org/show_bug.cgi?id=238455
+
+        Reviewed by Eric Carlson.
+
+        Covered by existing tests.
+
+        * platform/graphics/cv/ImageTransferSessionVT.mm:
+        (WebCore::ImageTransferSessionVT::setSize):
+        We check the Expected, then move the RetainPtr if available.
+
 2022-03-28  Tyler Wilcock  <tyle...@apple.com>
 
         AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else

Modified: trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm (291968 => 291969)


--- trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm	2022-03-28 16:28:57 UTC (rev 291968)
+++ trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm	2022-03-28 16:43:04 UTC (rev 291969)
@@ -77,10 +77,10 @@
 {
     if (m_size == size && m_outputBufferPool)
         return true;
-    auto bufferPool = createCVPixelBufferPool(size.width(), size.height(), m_pixelFormat, 6, false, m_shouldUseIOSurface).value_or(nullptr);
+    auto bufferPool = createCVPixelBufferPool(size.width(), size.height(), m_pixelFormat, 6, false, m_shouldUseIOSurface);
     if (!bufferPool)
         return false;
-    m_outputBufferPool = WTFMove(bufferPool);
+    m_outputBufferPool = WTFMove(*bufferPool);
     m_size = size;
     return true;
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to