Title: [291994] trunk/Source/WebKit
- Revision
- 291994
- Author
- hironori.fu...@sony.com
- Date
- 2022-03-28 15:02:29 -0700 (Mon, 28 Mar 2022)
Log Message
Unreviewed build fix after 291979 for WinCairo and PlayStation Debug builds
https://bugs.webkit.org/show_bug.cgi?id=238400
> WebNotificationManager.cpp(153): error C2027: use of undefined type 'WebCore::Notification'
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Guarded the LOG with ENABLE(NOTIFICATIONS).
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (291993 => 291994)
--- trunk/Source/WebKit/ChangeLog 2022-03-28 21:53:02 UTC (rev 291993)
+++ trunk/Source/WebKit/ChangeLog 2022-03-28 22:02:29 UTC (rev 291994)
@@ -1,3 +1,13 @@
+2022-03-28 Fujii Hironori <hironori.fu...@sony.com>
+
+ Unreviewed build fix after 291979 for WinCairo and PlayStation Debug builds
+ https://bugs.webkit.org/show_bug.cgi?id=238400
+
+ > WebNotificationManager.cpp(153): error C2027: use of undefined type 'WebCore::Notification'
+
+ * WebProcess/Notifications/WebNotificationManager.cpp:
+ (WebKit::WebNotificationManager::show): Guarded the LOG with ENABLE(NOTIFICATIONS).
+
2022-03-28 Chris Dumez <cdu...@apple.com>
Prepare WebCore for making the String(const char*) constructor explicit
Modified: trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp (291993 => 291994)
--- trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp 2022-03-28 21:53:02 UTC (rev 291993)
+++ trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp 2022-03-28 22:02:29 UTC (rev 291994)
@@ -150,10 +150,10 @@
bool WebNotificationManager::show(Notification& notification, WebPage* page)
{
+#if ENABLE(NOTIFICATIONS)
LOG(Notifications, "WebProcess %i going to show notification %s", getpid(), notification.identifier().toString().utf8().data());
ASSERT(isMainRunLoop());
-#if ENABLE(NOTIFICATIONS)
if (page && !page->corePage()->settings().notificationsEnabled())
return false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
