Title: [292029] trunk
- Revision
- 292029
- Author
- n...@apple.com
- Date
- 2022-03-29 05:24:28 -0700 (Tue, 29 Mar 2022)
Log Message
Use Canvas/CanvasText system colors for <dialog> default styling
https://bugs.webkit.org/show_bug.cgi?id=238425
Reviewed by Antti Koivisto.
Per HTML spec change: https://github.com/whatwg/html/commit/22154a4c1d426dddf187fb12c05fbcb8816c94a5
Main change is that the colors now adapt to dark mode by default.
LayoutTests/imported/w3c:
Updated test result to pass.
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt:
Source/WebCore:
Test: LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color.html
* css/dialog.css:
(dialog):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292028 => 292029)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-29 12:21:13 UTC (rev 292028)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-29 12:24:28 UTC (rev 292029)
@@ -1,5 +1,19 @@
2022-03-29 Tim Nguyen <n...@apple.com>
+ Use Canvas/CanvasText system colors for <dialog> default styling
+ https://bugs.webkit.org/show_bug.cgi?id=238425
+
+ Reviewed by Antti Koivisto.
+
+ Per HTML spec change: https://github.com/whatwg/html/commit/22154a4c1d426dddf187fb12c05fbcb8816c94a5
+ Main change is that the colors now adapt to dark mode by default.
+
+ Updated test result to pass.
+
+ * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt:
+
+2022-03-29 Tim Nguyen <n...@apple.com>
+
Re-import inert and <dialog> WPT
https://bugs.webkit.org/show_bug.cgi?id=238502
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt (292028 => 292029)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt 2022-03-29 12:21:13 UTC (rev 292028)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt 2022-03-29 12:24:28 UTC (rev 292029)
@@ -1,5 +1,5 @@
This is a dialog This is a dialog This is a dialog
PASS <dialog> color and background match default
-FAIL <dialog> colors react to dark mode assert_not_equals: Dialog color should react to color-scheme got disallowed value "rgb(0, 0, 0)"
+PASS <dialog> colors react to dark mode
Modified: trunk/Source/WebCore/ChangeLog (292028 => 292029)
--- trunk/Source/WebCore/ChangeLog 2022-03-29 12:21:13 UTC (rev 292028)
+++ trunk/Source/WebCore/ChangeLog 2022-03-29 12:24:28 UTC (rev 292029)
@@ -1,3 +1,18 @@
+2022-03-29 Tim Nguyen <n...@apple.com>
+
+ Use Canvas/CanvasText system colors for <dialog> default styling
+ https://bugs.webkit.org/show_bug.cgi?id=238425
+
+ Reviewed by Antti Koivisto.
+
+ Per HTML spec change: https://github.com/whatwg/html/commit/22154a4c1d426dddf187fb12c05fbcb8816c94a5
+ Main change is that the colors now adapt to dark mode by default.
+
+ Test: LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color.html
+
+ * css/dialog.css:
+ (dialog):
+
2022-03-29 Youenn Fablet <you...@apple.com>
RealtimeMediaSource::Type::Video is misleading as it is actually referring to camera sources
Modified: trunk/Source/WebCore/css/dialog.css (292028 => 292029)
--- trunk/Source/WebCore/css/dialog.css 2022-03-29 12:21:13 UTC (rev 292028)
+++ trunk/Source/WebCore/css/dialog.css 2022-03-29 12:24:28 UTC (rev 292029)
@@ -7,8 +7,8 @@
margin: auto;
border: solid;
padding: 1em;
- background: white;
- color: black;
+ background-color: Canvas;
+ color: CanvasText;
display: none;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
