Title: [292054] trunk/Source/WebCore
- Revision
- 292054
- Author
- za...@apple.com
- Date
- 2022-03-29 12:10:01 -0700 (Tue, 29 Mar 2022)
Log Message
WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1
https://bugs.webkit.org/show_bug.cgi?id=238465
<rdar://80630664>
Reviewed by Antti Koivisto.
The !gridLineHeight check was added to avoid division by zero but the integral roundToInt() may also produce a 0 value for
gridLineHeight.
* rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::lineSnapAdjustment const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (292053 => 292054)
--- trunk/Source/WebCore/ChangeLog 2022-03-29 19:08:10 UTC (rev 292053)
+++ trunk/Source/WebCore/ChangeLog 2022-03-29 19:10:01 UTC (rev 292054)
@@ -1,3 +1,17 @@
+2022-03-29 Alan Bujtas <za...@apple.com>
+
+ WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1
+ https://bugs.webkit.org/show_bug.cgi?id=238465
+ <rdar://80630664>
+
+ Reviewed by Antti Koivisto.
+
+ The !gridLineHeight check was added to avoid division by zero but the integral roundToInt() may also produce a 0 value for
+ gridLineHeight.
+
+ * rendering/LegacyRootInlineBox.cpp:
+ (WebCore::LegacyRootInlineBox::lineSnapAdjustment const):
+
2022-03-29 Eric Carlson <eric.carl...@apple.com>
[macOS] Muted video is sometimes paused when entering fullscreen
Modified: trunk/Source/WebCore/rendering/LegacyRootInlineBox.cpp (292053 => 292054)
--- trunk/Source/WebCore/rendering/LegacyRootInlineBox.cpp 2022-03-29 19:08:10 UTC (rev 292053)
+++ trunk/Source/WebCore/rendering/LegacyRootInlineBox.cpp 2022-03-29 19:10:01 UTC (rev 292054)
@@ -360,7 +360,7 @@
// FIXME: Need to handle crazy line-box-contain values that cause the root line box to not be considered. I assume
// the grid should honor line-box-contain.
LayoutUnit gridLineHeight = lineGridBox->lineBoxBottom() - lineGridBox->lineBoxTop();
- if (!gridLineHeight)
+ if (!roundToInt(gridLineHeight))
return 0;
LayoutUnit lineGridFontAscent = lineGrid->style().metricsOfPrimaryFont().ascent(baselineType());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
