Title: [292090] branches/safari-613-branch/Source/WebKit
- Revision
- 292090
- Author
- alanc...@apple.com
- Date
- 2022-03-29 18:35:55 -0700 (Tue, 29 Mar 2022)
Log Message
Cherry-pick r290840. rdar://problem/90957274
[WebAuthn] Don't use decidePolicyForLocalAuthenticator for Web Authentication Modern
https://bugs.webkit.org/show_bug.cgi?id=225646
rdar://78147681
Reviewed by Brent Fulgham.
decidePolicyForLocalAuthenticator is not implemented for the _WKWebAuthenticationPanelDelegate
used for modern because the prompt to allow Touch/FaceID comes earlier in the process.
* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::makeCredential):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (292089 => 292090)
--- branches/safari-613-branch/Source/WebKit/ChangeLog 2022-03-30 01:35:53 UTC (rev 292089)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog 2022-03-30 01:35:55 UTC (rev 292090)
@@ -1,3 +1,36 @@
+2022-03-29 Russell Epstein <repst...@apple.com>
+
+ Cherry-pick r290840. rdar://problem/90957274
+
+ [WebAuthn] Don't use decidePolicyForLocalAuthenticator for Web Authentication Modern
+ https://bugs.webkit.org/show_bug.cgi?id=225646
+ rdar://78147681
+
+ Reviewed by Brent Fulgham.
+
+ decidePolicyForLocalAuthenticator is not implemented for the _WKWebAuthenticationPanelDelegate
+ used for modern because the prompt to allow Touch/FaceID comes earlier in the process.
+
+ * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+ (WebKit::LocalAuthenticator::makeCredential):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-03-04 J Pascoe <j_pas...@apple.com>
+
+ [WebAuthn] Don't use decidePolicyForLocalAuthenticator for Web Authentication Modern
+ https://bugs.webkit.org/show_bug.cgi?id=225646
+ rdar://78147681
+
+ Reviewed by Brent Fulgham.
+
+ decidePolicyForLocalAuthenticator is not implemented for the _WKWebAuthenticationPanelDelegate
+ used for modern because the prompt to allow Touch/FaceID comes earlier in the process.
+
+ * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+ (WebKit::LocalAuthenticator::makeCredential):
+
2022-03-29 Alex Christensen <achristen...@webkit.org>
Revert r292055
Modified: branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (292089 => 292090)
--- branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-03-30 01:35:53 UTC (rev 292089)
+++ branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-03-30 01:35:55 UTC (rev 292090)
@@ -238,7 +238,11 @@
else
weakThis->receiveException({ NotAllowedError, "This request has been cancelled by the user."_s });
};
- observer()->decidePolicyForLocalAuthenticator(WTFMove(callback));
+ // Similar to below, consent has already been given.
+ if (webAuthenticationModernEnabled())
+ callback(LocalAuthenticatorPolicy::Allow);
+ else
+ observer()->decidePolicyForLocalAuthenticator(WTFMove(callback));
return;
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
