Title: [292094] trunk/Source/WebCore
- Revision
- 292094
- Author
- dp...@igalia.com
- Date
- 2022-03-29 18:57:04 -0700 (Tue, 29 Mar 2022)
Log Message
[GCC] Ubuntu LTS build broken after r291956
https://bugs.webkit.org/show_bug.cgi?id=238481
Reviewed by Darin Adler.
Default comparisons by value (P1946R0) is only supported since GCC10.
https://en.cppreference.com/w/cpp/compiler_support/20
* rendering/style/StyleGridData.h:
(WebCore::GridTrackEntrySubgrid::operator== const):
(WebCore::GridTrackEntryRepeat::operator== const):
(WebCore::GridTrackEntryAutoRepeat::operator== const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (292093 => 292094)
--- trunk/Source/WebCore/ChangeLog 2022-03-30 01:36:23 UTC (rev 292093)
+++ trunk/Source/WebCore/ChangeLog 2022-03-30 01:57:04 UTC (rev 292094)
@@ -1,3 +1,18 @@
+2022-03-29 Diego Pino Garcia <dp...@igalia.com>
+
+ [GCC] Ubuntu LTS build broken after r291956
+ https://bugs.webkit.org/show_bug.cgi?id=238481
+
+ Reviewed by Darin Adler.
+
+ Default comparisons by value (P1946R0) is only supported since GCC10.
+ https://en.cppreference.com/w/cpp/compiler_support/20
+
+ * rendering/style/StyleGridData.h:
+ (WebCore::GridTrackEntrySubgrid::operator== const):
+ (WebCore::GridTrackEntryRepeat::operator== const):
+ (WebCore::GridTrackEntryAutoRepeat::operator== const):
+
2022-03-29 Tyler Wilcock <tyle...@apple.com>
AX: Don't detach children in AXIsolatedTree::applyPendingChanges for nodes being updated (removed and added)
Modified: trunk/Source/WebCore/rendering/style/StyleGridData.h (292093 => 292094)
--- trunk/Source/WebCore/rendering/style/StyleGridData.h 2022-03-30 01:36:23 UTC (rev 292093)
+++ trunk/Source/WebCore/rendering/style/StyleGridData.h 2022-03-30 01:57:04 UTC (rev 292094)
@@ -44,16 +44,25 @@
typedef Vector<RepeatEntry> RepeatTrackList;
struct GridTrackEntrySubgrid {
- bool operator==(const GridTrackEntrySubgrid&) const = default;
+ bool operator==(const GridTrackEntrySubgrid&) const
+ {
+ return true;
+ }
};
struct GridTrackEntryRepeat {
- bool operator==(const GridTrackEntryRepeat&) const = default;
+ bool operator==(const GridTrackEntryRepeat& other) const
+ {
+ return repeats == other.repeats && list == other.list;
+ }
unsigned repeats;
RepeatTrackList list;
};
struct GridTrackEntryAutoRepeat {
- bool operator==(const GridTrackEntryAutoRepeat&) const = default;
+ bool operator==(const GridTrackEntryAutoRepeat& other) const
+ {
+ return type == other.type && list == other.list;
+ }
AutoRepeatType type;
RepeatTrackList list;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
