Title: [292167] trunk/Tools
- Revision
- 292167
- Author
- je...@apple.com
- Date
- 2022-03-31 13:07:32 -0700 (Thu, 31 Mar 2022)
Log Message
Some API tests are missing header imports
https://bugs.webkit.org/show_bug.cgi?id=238588
Reviewed by Alexey Proskuryakov.
I attempted to add a new API test which changed the source files that are compiled in each
UnifiedSource file. This revealed that some existing API tests were only compiling successfully
because they relied on headers being imported by other source files in the same UnifiedSource
compilation unit.
* TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:
* TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (292166 => 292167)
--- trunk/Tools/ChangeLog 2022-03-31 20:05:12 UTC (rev 292166)
+++ trunk/Tools/ChangeLog 2022-03-31 20:07:32 UTC (rev 292167)
@@ -1,3 +1,19 @@
+2022-03-31 Jeff Miller <je...@apple.com>
+
+ Some API tests are missing header imports
+ https://bugs.webkit.org/show_bug.cgi?id=238588
+
+ Reviewed by Alexey Proskuryakov.
+
+ I attempted to add a new API test which changed the source files that are compiled in each
+ UnifiedSource file. This revealed that some existing API tests were only compiling successfully
+ because they relied on headers being imported by other source files in the same UnifiedSource
+ compilation unit.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:
+ * TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
+ * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
+
2022-03-31 Robert Jenner <jen...@apple.com>
REGRESSION(r288464?):[ iOS15 Release GPUP arm64 ]TestWebKitAPI.GPUProcess.E xitsUnderMemoryPressureWebR TCCase is a constant failure
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm (292166 => 292167)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm 2022-03-31 20:05:12 UTC (rev 292166)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm 2022-03-31 20:07:32 UTC (rev 292167)
@@ -28,7 +28,9 @@
#if USE(APPLE_INTERNAL_SDK)
#import "DeprecatedGlobalValues.h"
+#import "HTTPServer.h"
#import "PlatformUtilities.h"
+#import "TestNavigationDelegate.h"
#import "TestUIDelegate.h"
#import "TestURLSchemeHandler.h"
#import "TestWKWebView.h"
@@ -36,6 +38,8 @@
#import <WebKit/WKWebViewConfigurationPrivate.h>
#import <WebKit/WKWebViewPrivate.h>
#import <WebKit/WKWebsiteDataRecordPrivate.h>
+#import <WebKit/WKWebsiteDataStorePrivate.h>
+#import <WebKit/_WKWebsiteDataStoreConfiguration.h>
@interface FileSystemAccessMessageHandler : NSObject <WKScriptMessageHandler>
@end
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm (292166 => 292167)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm 2022-03-31 20:05:12 UTC (rev 292166)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm 2022-03-31 20:07:32 UTC (rev 292167)
@@ -36,8 +36,10 @@
#import "UIKitSPI.h"
#import "WKWebViewConfigurationExtras.h"
#import <WebCore/LocalizedStrings.h>
+#import <WebKit/WKPreferencesPrivate.h>
#import <WebKit/WKWebViewPrivate.h>
#import <WebKit/WKWebViewPrivateForTesting.h>
+#import <WebKit/_WKInternalDebugFeature.h>
#import <pal/cocoa/VisionKitCoreSoftLink.h>
#import <pal/spi/cocoa/VisionKitCoreSPI.h>
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm (292166 => 292167)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm 2022-03-31 20:05:12 UTC (rev 292166)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm 2022-03-31 20:07:32 UTC (rev 292167)
@@ -27,6 +27,7 @@
#import "HTTPServer.h"
#import "PlatformUtilities.h"
+#import "Test.h"
#import "TestWKWebView.h"
#import "Utilities.h"
#import <WebKit/WKProcessPoolPrivate.h>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
