Title: [292566] trunk/LayoutTests
- Revision
- 292566
- Author
- drou...@apple.com
- Date
- 2022-04-07 14:15:43 -0700 (Thu, 07 Apr 2022)
Log Message
[GPU Process] Test failures in forms
https://bugs.webkit.org/show_bug.cgi?id=236927
<rdar://problem/89196867>
Unreviewed, fix test failures and adjust related expectations.
* fast/forms/autofocus-readonly-attribute.html:
This test appeared to be failing because it ended before the `"focus"` event had a chance
to fire. Make the test async by delaying its completion until after a `requestAnimationFrame`
which should be enough time for the `"focus"` event to be dispatched (and handled).
* fast/forms/input-text-autofocus.html:
* fast/forms/input-text-autofocus-expected.txt:
Slightly rework this test to manually tell the `testRunner` to `waitUntilDone`, as for some
reason the `js-test-{pre,post}` test harness seems to somehow not output the `PASS` messages
while still finishing the test (i.e. not a timeout).
* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-wk2/TestExpectations:
* platform/ipad/TestExpectations:
Remove non-skipped expectations for:
- fast/forms/ios/choose-select-option.html
- fast/forms/autofocus-readonly-attribute.html
- fast/forms/input-text-autofocus.html
Note that `fast/forms/ios/choose-select-option.html` is still skipped on iPad, because there
is already a `platform/ipad/fast/forms/choose-select-option.html` specifically to test iPad.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (292565 => 292566)
--- trunk/LayoutTests/ChangeLog 2022-04-07 21:05:05 UTC (rev 292565)
+++ trunk/LayoutTests/ChangeLog 2022-04-07 21:15:43 UTC (rev 292566)
@@ -1,3 +1,32 @@
+2022-04-07 Devin Rousso <drou...@apple.com>
+
+ [GPU Process] Test failures in forms
+ https://bugs.webkit.org/show_bug.cgi?id=236927
+ <rdar://problem/89196867>
+
+ Unreviewed, fix test failures and adjust related expectations.
+
+ * fast/forms/autofocus-readonly-attribute.html:
+ This test appeared to be failing because it ended before the `"focus"` event had a chance
+ to fire. Make the test async by delaying its completion until after a `requestAnimationFrame`
+ which should be enough time for the `"focus"` event to be dispatched (and handled).
+
+ * fast/forms/input-text-autofocus.html:
+ * fast/forms/input-text-autofocus-expected.txt:
+ Slightly rework this test to manually tell the `testRunner` to `waitUntilDone`, as for some
+ reason the `js-test-{pre,post}` test harness seems to somehow not output the `PASS` messages
+ while still finishing the test (i.e. not a timeout).
+
+ * platform/ios-simulator-wk2/TestExpectations:
+ * platform/ios-wk2/TestExpectations:
+ * platform/ipad/TestExpectations:
+ Remove non-skipped expectations for:
+ - fast/forms/ios/choose-select-option.html
+ - fast/forms/autofocus-readonly-attribute.html
+ - fast/forms/input-text-autofocus.html
+ Note that `fast/forms/ios/choose-select-option.html` is still skipped on iPad, because there
+ is already a `platform/ipad/fast/forms/choose-select-option.html` specifically to test iPad.
+
2022-04-07 Tyler Wilcock <tyle...@apple.com>
AX ITM: ARIATreeItemContent, ARIATreeRows, and DisclosedRows properties need to be updated after dynamic page changes
Modified: trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html (292565 => 292566)
--- trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html 2022-04-07 21:05:05 UTC (rev 292565)
+++ trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html 2022-04-07 21:15:43 UTC (rev 292566)
@@ -2,13 +2,19 @@
<html>
<head>
<script>
-if (window.testRunner)
+if (window.testRunner) {
testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
function log(msg) {
var console = document.getElementById("console");
console.innerText = msg;
}
+
+requestAnimationFrame(() => {
+ window.testRunner?.notifyDone();
+});
</script>
</head>
<body>
Modified: trunk/LayoutTests/fast/forms/input-text-autofocus-expected.txt (292565 => 292566)
--- trunk/LayoutTests/fast/forms/input-text-autofocus-expected.txt 2022-04-07 21:05:05 UTC (rev 292565)
+++ trunk/LayoutTests/fast/forms/input-text-autofocus-expected.txt 2022-04-07 21:15:43 UTC (rev 292566)
@@ -1,8 +1,5 @@
Test for <input autofocus>
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
PASS inputFocusCount is 1
PASS input.selectionStart is 0
PASS input.selectionEnd is 0
Modified: trunk/LayoutTests/fast/forms/input-text-autofocus.html (292565 => 292566)
--- trunk/LayoutTests/fast/forms/input-text-autofocus.html 2022-04-07 21:05:05 UTC (rev 292565)
+++ trunk/LayoutTests/fast/forms/input-text-autofocus.html 2022-04-07 21:15:43 UTC (rev 292566)
@@ -1,23 +1,29 @@
<!DOCTYPE html>
<html>
<head>
-<script src=""
-<script src=""
</head>
<body>
+<p>Test for <input autofocus></p>
+<div id="console"></div>
+
<input id="input" type="text" value="foo" autofocus>
<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+
// iOS places the caret at the end of the input field.
if (window.internals)
internals.settings.setEditingBehavior("mac");
-description("Test for <input autofocus>");
+function log(msg) {
+ document.getElementById("console").appendChild(document.createElement("div")).textContent = msg;
+}
-jsTestIsAsync = true;
-
inputFocusCount = 0;
input.addEventListener("focus", (event) => {
++inputFocusCount;
@@ -24,15 +30,13 @@
});
requestAnimationFrame(() => {
- shouldBe("inputFocusCount", "1");
- shouldBe("input.selectionStart", "0");
- shouldBe("input.selectionEnd", "0");
+ log(`${inputFocusCount === 1 ? "PASS" : "FAIL"} inputFocusCount is 1`);
+ log(`${input.selectionStart === 0 ? "PASS" : "FAIL"} input.selectionStart is 0`);
+ log(`${input.selectionEnd === 0 ? "PASS" : "FAIL"} input.selectionEnd is 0`);
- finishJSTest();
+ window.testRunner?.notifyDone();
});
</script>
-
-<script src=""
</body>
</html>
Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (292565 => 292566)
--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2022-04-07 21:05:05 UTC (rev 292565)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2022-04-07 21:15:43 UTC (rev 292566)
@@ -175,7 +175,5 @@
webkit.org/b/236928 imported/w3c/web-platform-tests/xhr/event-timeout-order.any.worker.html [ Failure Pass ]
webkit.org/b/236926 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html [ Failure Pass ]
webkit.org/b/236926 webrtc/vp9-profile2.html [ Timeout Pass ]
-webkit.org/b/236927 fast/forms/ios/choose-select-option.html [ Timeout Pass ]
-webkit.org/b/236927 fast/forms/input-text-autofocus.html [ Pass Failure ]
# This passes only on the arm64 host
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adopt-from-image-document.html [ Pass ImageOnlyFailure ]
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (292565 => 292566)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 21:05:05 UTC (rev 292565)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 21:15:43 UTC (rev 292566)
@@ -2221,8 +2221,6 @@
############ end of test failures related to GPU Process on by default
-webkit.org/b/236927 fast/forms/autofocus-readonly-attribute.html [ Failure Pass ]
-
# webkit.org/b/237346 REGRESSION(r290539): [ iOS ] 2X http/wpt/webauthn/public-key-credential-create-failure-local (layout-tests) are constant text failures
http/wpt/webauthn/public-key-credential-create-failure-local.https.html [ Pass Failure ]
http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/ipad/TestExpectations (292565 => 292566)
--- trunk/LayoutTests/platform/ipad/TestExpectations 2022-04-07 21:05:05 UTC (rev 292565)
+++ trunk/LayoutTests/platform/ipad/TestExpectations 2022-04-07 21:15:43 UTC (rev 292566)
@@ -25,7 +25,6 @@
media/video-background-playback.html [ Pass Crash ]
fast/forms/ios/scroll-to-reveal-focused-select.html [ Crash Failure ]
fast/forms/ios/time-picker-value-change.html [ Failure ]
-fast/forms/ios/choose-select-option.html [ Timeout ]
fast/forms/ios/delete-in-input-in-iframe.html [ Timeout ]
[ Debug ] fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html [ Timeout ]
fast/forms/ios/typing-in-input-in-iframe.html [ Timeout ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
