Title: [292695] trunk/Source/WebKit
- Revision
- 292695
- Author
- hironori.fu...@sony.com
- Date
- 2022-04-10 21:25:57 -0700 (Sun, 10 Apr 2022)
Log Message
[WinCairo] Child process happens to remain alive even after IPC::Connection is disconnected
https://bugs.webkit.org/show_bug.cgi?id=204221
Reviewed by Don Olmstead.
After running layout tests, I observed some processes of
WebKitWebProcess.exe and WebKitNetworkProcess.exe were still
alive. These child processed should exit if the named pipe of
IPC::Connection is broken.
* Platform/IPC/win/ConnectionWin.cpp:
(IPC::Connection::readEventHandler): Call connectionDidClose() in the case of ERROR_BROKEN_PIPE.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (292694 => 292695)
--- trunk/Source/WebKit/ChangeLog 2022-04-11 04:22:48 UTC (rev 292694)
+++ trunk/Source/WebKit/ChangeLog 2022-04-11 04:25:57 UTC (rev 292695)
@@ -1,3 +1,18 @@
+2022-04-10 Fujii Hironori <hironori.fu...@sony.com>
+
+ [WinCairo] Child process happens to remain alive even after IPC::Connection is disconnected
+ https://bugs.webkit.org/show_bug.cgi?id=204221
+
+ Reviewed by Don Olmstead.
+
+ After running layout tests, I observed some processes of
+ WebKitWebProcess.exe and WebKitNetworkProcess.exe were still
+ alive. These child processed should exit if the named pipe of
+ IPC::Connection is broken.
+
+ * Platform/IPC/win/ConnectionWin.cpp:
+ (IPC::Connection::readEventHandler): Call connectionDidClose() in the case of ERROR_BROKEN_PIPE.
+
2022-04-09 Simon Fraser <simon.fra...@apple.com>
Put layer backing store buffers into the per-RemoteRenderingBackend IOSurfacePool
Modified: trunk/Source/WebKit/Platform/IPC/win/ConnectionWin.cpp (292694 => 292695)
--- trunk/Source/WebKit/Platform/IPC/win/ConnectionWin.cpp 2022-04-11 04:22:48 UTC (rev 292694)
+++ trunk/Source/WebKit/Platform/IPC/win/ConnectionWin.cpp 2022-04-11 04:25:57 UTC (rev 292695)
@@ -195,8 +195,10 @@
continue;
}
- if (error == ERROR_BROKEN_PIPE)
+ if (error == ERROR_BROKEN_PIPE) {
+ connectionDidClose();
return;
+ }
// FIXME: We need to handle other errors here.
ASSERT_NOT_REACHED();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
