Diff
Modified: trunk/LayoutTests/ChangeLog (292952 => 292953)
--- trunk/LayoutTests/ChangeLog 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/ChangeLog 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,3 +1,18 @@
+2022-04-18 Martin Robinson <mrobin...@webkit.org>
+
+ TestRunner testdriver does not properly focus elements before sending keys to them
+ https://bugs.webkit.org/show_bug.cgi?id=237589
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt: Added.
+ * platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt.
+ * platform/ios/TestExpectations:
+ * platform/mac-wk1/TestExpectations:
+ * platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt: Added.
+ * platform/mac/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt: Added.
+ * platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt:
+
2022-04-16 Ryosuke Niwa <rn...@webkit.org>
Make release assertion in Document::updateLayout more precise for FrameSelection::setSelection
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,3 +1,24 @@
+2022-04-18 Martin Robinson <mrobin...@webkit.org>
+
+ TestRunner testdriver does not properly focus elements before sending keys to them
+ https://bugs.webkit.org/show_bug.cgi?id=237589
+
+ Reviewed by Carlos Garcia Campos.
+
+ * web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt:
+ * web-platform-tests/css/css-scroll-snap/input/keyboard.html:
+ * web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary-expected.txt:
+ * web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary.html:
+ * web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt:
+ * web-platform-tests/html/semantics/forms/textfieldselection/selection-expected.txt:
+ * web-platform-tests/html/semantics/forms/the-input-element/defaultValue-clobbering-expected.txt:
+ * web-platform-tests/html/semantics/forms/the-input-element/email-set-value-expected.txt:
+ * web-platform-tests/html/semantics/forms/the-input-element/maxlength-number-expected.txt:
+ * web-platform-tests/html/semantics/forms/the-input-element/radio-double-activate-pseudo-expected.txt:
+ * web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt:
+ * web-platform-tests/resources/testdriver-vendor.js: When sending keys, first focus the element
+ in question.
+
2022-04-15 Matteo Flores <matteo_flo...@apple.com>
REBASLINE: [ Monterey wk2 ] 7 /paymentrequest/* tests are constant text failures
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,12 +1,12 @@
Harness Error (TIMEOUT), message = null
-TIMEOUT Snaps to bottom-left after pressing ArrowDown Test timed out
-NOTRUN Snaps to top-left after pressing ArrowUp
-NOTRUN Snaps to top-right after pressing ArrowRight
-NOTRUN Snaps to top-left after pressing ArrowLeft
-NOTRUN If the original intended offset is valid as making a snap area cover thesnapport, and there's no other snap offset in between, use the originalintended offset
-NOTRUN If the original intended offset is valid as making a snap area cover the snapport, but there's a defined snap offset in between, use the defined snap offset.
+PASS Snaps to bottom-left after pressing ArrowDown
+PASS Snaps to top-left after pressing ArrowUp
+PASS Snaps to top-right after pressing ArrowRight
+PASS Snaps to top-left after pressing ArrowLeft
+PASS If the original intended offset is valid as making a snap area cover thesnapport, and there's no other snap offset in between, use the originalintended offset
+TIMEOUT If the original intended offset is valid as making a snap area cover the snapport, but there's a defined snap offset in between, use the defined snap offset. Test timed out
NOTRUN If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is mandatory, stay at the current offset.
NOTRUN If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is proximity, go to the original intended offset
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard.html (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard.html 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard.html 2022-04-18 12:35:13 UTC (rev 292953)
@@ -16,7 +16,7 @@
<script src=""
-<div id="scroller">
+<div id="scroller" tabindex="0">
<div id="space"></div>
<div class="snap left top" id="top-left"></div>
<div class="snap right top" id="top-right"></div>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary-expected.txt (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,8 +1,6 @@
Header 1Footer 1
Header 2Footer 2
-Harness Error (TIMEOUT), message = null
+FAIL Keyboard scrolling with vertical snap-area overflow assert_equals: End boundary of snap-area is valid snap target expected 39 but got 449
+FAIL Mouse-wheel scrolling with vertical snap-area overflow promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: action"
-TIMEOUT Keyboard scrolling with vertical snap-area overflow Test timed out
-NOTRUN Mouse-wheel scrolling with vertical snap-area overflow
-
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary.html (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary.html 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary.html 2022-04-18 12:35:13 UTC (rev 292953)
@@ -37,7 +37,7 @@
<script src=""
<script src=""
-<div id="scroller">
+<div id="scroller" tabindex="0">
<div id="target" class="box">
<div class="header">Header 1</div>
<div class="footer">Footer 1</div>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -4,13 +4,13 @@
PASS <input type="checkbox"> click()
PASS <input type="radio"> click()
-FAIL <input type="text"> typing promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
-FAIL <input type="search"> typing promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
-FAIL <input type="tel"> typing promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
-FAIL <input type="url"> typing promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
-FAIL <input type="email"> typing promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
-FAIL <input type="password"> typing promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
-FAIL <input type="number"> typing promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
-FAIL <textarea></textarea> typing promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
+PASS <input type="text"> typing
+PASS <input type="search"> typing
+PASS <input type="tel"> typing
+PASS <input type="url"> typing
+PASS <input type="email"> typing
+PASS <input type="password"> typing
+PASS <input type="number"> typing
+PASS <textarea></textarea> typing
FAIL <select> pressing down arrow promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'e.bubbles')"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/defaultValue-clobbering-expected.txt (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/defaultValue-clobbering-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/defaultValue-clobbering-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,6 +1,6 @@
email with leading whitespace:
number with trailing incomplete exponent:
-FAIL Visible value and validity should not be affected when assigning to the defaultValue property for type=email. assert_false: " user" should not be a valid value for type=email. expected false got true
-FAIL Visible value and validity should not be affected when assigning to the defaultValue property for type=number. assert_false: "123e" should not be a valid value for type=number. expected false got true
+PASS Visible value and validity should not be affected when assigning to the defaultValue property for type=email.
+PASS Visible value and validity should not be affected when assigning to the defaultValue property for type=number.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value-expected.txt (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,4 +1,4 @@
-FAIL setValue(sanitizedValue) is reflected in visible text field content assert_equals: value is sanitized expected "foo@bar" but got ""
+FAIL setValue(sanitizedValue) is reflected in visible text field content assert_equals: visible value is sanitized after setValue(sanitized) expected "foo@bar" but got " foo@bar "
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/maxlength-number-expected.txt (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/maxlength-number-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/maxlength-number-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,4 +1,4 @@
-FAIL maxlength doesn't apply to input type=number assert_equals: expected "1234" but got ""
+PASS maxlength doesn't apply to input type=number
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-double-activate-pseudo-expected.txt (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-double-activate-pseudo-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-double-activate-pseudo-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,4 +1,4 @@
-PASS <input type=radio> shouldn't have the :active pseudo element after pressing the spacebar twice.
+FAIL <input type=radio> shouldn't have the :active pseudo element after pressing the spacebar twice. assert_equals: If the radio doesn't have the :active pseudo selector, nothing else should either. expected null but got Element node <input type="radio" id="radioinput"></input>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1,4 +1,4 @@
-FAIL Cloned invalid inputs / textareas with interactive changes get their validity state copied correctly assert_true: input should match :invalid expected true got false
+FAIL Cloned invalid inputs / textareas with interactive changes get their validity state copied correctly assert_true: input clone should match :invalid expected true got false
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (292952 => 292953)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2022-04-18 12:35:13 UTC (rev 292953)
@@ -153,6 +153,8 @@
if (!window.eventSender)
return Promise.reject(new Error("window.eventSender is undefined."));
+ element.focus();
+
// https://seleniumhq.github.io/selenium/docs/api/py/webdriver/selenium.webdriver.common.keys.html
// FIXME: Add more cases.
const SeleniumCharCodeToEventSenderKey = {
Added: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt (0 => 292953)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -0,0 +1,16 @@
+
+
+ Clickable
+
+PASS <input type="checkbox"> click()
+PASS <input type="radio"> click()
+PASS <input type="text"> typing
+PASS <input type="search"> typing
+PASS <input type="tel"> typing
+PASS <input type="url"> typing
+PASS <input type="email"> typing
+PASS <input type="password"> typing
+PASS <input type="number"> typing
+PASS <textarea></textarea> typing
+PASS <select> pressing down arrow
+
Modified: trunk/LayoutTests/platform/ios/TestExpectations (292952 => 292953)
--- trunk/LayoutTests/platform/ios/TestExpectations 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1033,6 +1033,13 @@
scrollbars/scrolling-by-page-ignoring-hidden-fixed-elements-on-keyboard-spacebar.html [ Skip ]
scrollbars/scrolling-by-page-ignoring-transparent-fixed-elements-on-keyboard-spacebar.html [ Skip ]
storage/domstorage/sessionstorage/set-item-synchronous-keydown.html [ Skip ]
+imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard.html [ Skip ]
+imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/defaultValue-clobbering.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/maxlength-number.html [ Skip ]
+imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-double-activate-pseudo.html [ Skip ]
# Tests that use EventSender's mouseMoveTo, mouseUp and mouseDown
css3/viewport-percentage-lengths/vh-resize.html [ Skip ]
Copied: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt (from rev 292952, trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt) (0 => 292953)
--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/invalid-after-clone-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -0,0 +1,4 @@
+
+
+FAIL Cloned invalid inputs / textareas with interactive changes get their validity state copied correctly assert_true: input should match :invalid expected true got false
+
Added: trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt (0 => 292953)
--- trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-scroll-snap/input/keyboard-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -0,0 +1,12 @@
+
+Harness Error (TIMEOUT), message = null
+
+FAIL Snaps to bottom-left after pressing ArrowDown assert_greater_than: expected a number greater than 2 but got 0
+FAIL Snaps to top-left after pressing ArrowUp assert_greater_than: expected a number greater than 2 but got 0
+FAIL Snaps to top-right after pressing ArrowRight assert_greater_than: expected a number greater than 2 but got 0
+FAIL Snaps to top-left after pressing ArrowLeft assert_greater_than: expected a number greater than 2 but got 0
+PASS If the original intended offset is valid as making a snap area cover thesnapport, and there's no other snap offset in between, use the originalintended offset
+TIMEOUT If the original intended offset is valid as making a snap area cover the snapport, but there's a defined snap offset in between, use the defined snap offset. Test timed out
+NOTRUN If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is mandatory, stay at the current offset.
+NOTRUN If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is proximity, go to the original intended offset
+
Modified: trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt (292952 => 292953)
--- trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -6,7 +6,5 @@
Tab to me and press ENTER.
I will be focused programmatically.
-Harness Error (TIMEOUT), message = null
+PASS Programmatic focus after keypress should match :focus-visible
-TIMEOUT Programmatic focus after keypress should match :focus-visible Test timed out
-
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (292952 => 292953)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-18 11:47:39 UTC (rev 292952)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-18 12:35:13 UTC (rev 292953)
@@ -1864,3 +1864,6 @@
http/tests/webgpu/webgpu/shader/validation/wgsl/basic.html [ Skip ]
webkit.org/b/238642 imported/w3c/web-platform-tests/css/css-contain/contain-body-overflow-002.html [ ImageOnlyFailure ]
+
+webkit.org/b/237783 imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties.html [ Timeout ]
+
Added: trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt (0 => 292953)
--- trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/input-change-event-properties-expected.txt 2022-04-18 12:35:13 UTC (rev 292953)
@@ -0,0 +1,18 @@
+
+
+ Clickable
+
+Harness Error (TIMEOUT), message = null
+
+PASS <input type="checkbox"> click()
+PASS <input type="radio"> click()
+PASS <input type="text"> typing
+PASS <input type="search"> typing
+PASS <input type="tel"> typing
+PASS <input type="url"> typing
+PASS <input type="email"> typing
+PASS <input type="password"> typing
+PASS <input type="number"> typing
+PASS <textarea></textarea> typing
+TIMEOUT <select> pressing down arrow Test timed out
+
