[webkit-changes] [292974] trunk/Tools/CISupport/build-webkit-org

Mon, 18 Apr 2022 14:54:53 -0700

Title: [292974] trunk/Tools/CISupport/build-webkit-org
Revision
292974
Author
e...@apple.com
Date
2022-04-18 14:54:01 -0700 (Mon, 18 Apr 2022)

Log Message

[buildbot] Increase the compile timeout to account for delayed output from clang/XCBuild
https://bugs.webkit.org/show_bug.cgi?id=239455

Reviewed by Aakash Jain.

* Tools/CISupport/build-webkit-org/steps.py:
(CompileWebKit):
(CompileWebKit.__init__): Change the default timeout to 30 minutes.
* Tools/CISupport/build-webkit-org/steps_unittest.py: Update
  expectations.
(TestCompileWebKit.test_success):
(TestCompileWebKit.test_success_gtk):
(TestCompileWebKit.test_success_wpe):
(TestCompileWebKit.test_failure):
(TestCompileJSCOnly.test_success):
(TestCompileJSCOnly.test_failure):

Canonical link: https://commits.webkit.org/249737@main

Modified Paths

Diff

Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (292973 => 292974)


--- trunk/Tools/CISupport/build-webkit-org/steps.py	2022-04-18 21:44:04 UTC (rev 292973)
+++ trunk/Tools/CISupport/build-webkit-org/steps.py	2022-04-18 21:54:01 UTC (rev 292974)
@@ -268,6 +268,12 @@
     descriptionDone = ["compiled"]
     warningPattern = ".*arning: .*"
 
+    def __init__(self, **kwargs):
+        # https://bugs.webkit.org/show_bug.cgi?id=239455: The timeout needs to be >20 min to
+        # work around log output delays on slower machines.
+        kwargs.setdefault('timeout', 60 * 30)
+        super().__init__(**kwargs)
+
     def start(self):
         platform = self.getProperty('platform')
         buildOnly = self.getProperty('buildOnly')

Modified: trunk/Tools/CISupport/build-webkit-org/steps_unittest.py (292973 => 292974)


--- trunk/Tools/CISupport/build-webkit-org/steps_unittest.py	2022-04-18 21:44:04 UTC (rev 292973)
+++ trunk/Tools/CISupport/build-webkit-org/steps_unittest.py	2022-04-18 21:54:01 UTC (rev 292974)
@@ -402,7 +402,7 @@
         self.expectRemoteCommands(
             ExpectShell(
                 workdir='wkdir',
-                timeout=1200,
+                timeout=1800,
                 logEnviron=True,
                 command=['perl', 'Tools/Scripts/build-webkit', '--release'],
             ) + 0,
@@ -418,7 +418,7 @@
         self.expectRemoteCommands(
             ExpectShell(
                 workdir='wkdir',
-                timeout=1200,
+                timeout=1800,
                 logEnviron=True,
                 command=['perl', 'Tools/Scripts/build-webkit', '--release', '--prefix=/app/webkit/WebKitBuild/Release/install', '--gtk'],
             ) + 0,
@@ -434,7 +434,7 @@
         self.expectRemoteCommands(
             ExpectShell(
                 workdir='wkdir',
-                timeout=1200,
+                timeout=1800,
                 logEnviron=True,
                 command=['perl', 'Tools/Scripts/build-webkit', '--release', '--wpe'],
             ) + 0,
@@ -449,7 +449,7 @@
         self.expectRemoteCommands(
             ExpectShell(
                 workdir='wkdir',
-                timeout=1200,
+                timeout=1800,
                 logEnviron=True,
                 command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
             ) + 2
@@ -474,7 +474,7 @@
         self.expectRemoteCommands(
             ExpectShell(
                 workdir='wkdir',
-                timeout=1200,
+                timeout=1800,
                 logEnviron=True,
                 command=['perl', 'Tools/Scripts/build-jsc', '--release'],
             ) + 0,
@@ -489,6 +489,7 @@
         self.expectRemoteCommands(
             ExpectShell(
                 workdir='wkdir',
+                timeout=1800,
                 logEnviron=True,
                 command=['perl', 'Tools/Scripts/build-jsc', '--debug'],
             ) + 2

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to