Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (107676 => 107677)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-02-14 07:48:45 UTC (rev 107676)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-02-14 07:54:48 UTC (rev 107677)
@@ -1,3 +1,17 @@
+2012-02-13 Mihai Parparita <mih...@chromium.org>
+
+ [Chromium] Remove BoundObject
+ https://bugs.webkit.org/show_bug.cgi?id=78531
+
+ Reviewed by Pavel Feldman.
+
+ Remove the BoundObject class, references to it were removed in r56999.
+
+ * WebKit.gyp:
+ * src/BoundObject.cpp: Removed.
+ * src/BoundObject.h: Removed.
+ * src/WebDevToolsFrontendImpl.cpp:
+
2012-02-13 W. James MacLean <wjmacl...@chromium.org>
[chromium] Remove obsolete zoom animation pathway.
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (107676 => 107677)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2012-02-14 07:48:45 UTC (rev 107676)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-02-14 07:54:48 UTC (rev 107677)
@@ -372,8 +372,6 @@
'src/BackForwardListChromium.h',
'src/BlobRegistryProxy.cpp',
'src/BlobRegistryProxy.h',
- 'src/BoundObject.cpp',
- 'src/BoundObject.h',
'src/CCThreadImpl.cpp',
'src/CCThreadImpl.h',
'src/ChromeClientImpl.cpp',
Deleted: trunk/Source/WebKit/chromium/src/BoundObject.cpp (107676 => 107677)
--- trunk/Source/WebKit/chromium/src/BoundObject.cpp 2012-02-14 07:48:45 UTC (rev 107676)
+++ trunk/Source/WebKit/chromium/src/BoundObject.cpp 2012-02-14 07:54:48 UTC (rev 107677)
@@ -1,80 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "BoundObject.h"
-
-#include "V8Binding.h"
-#include "V8Proxy.h"
-
-namespace WebKit {
-
-BoundObject::BoundObject(v8::Handle<v8::Context> context, void* v8This, const char* objectName)
- : m_objectName(objectName)
- , m_context(context)
- , m_v8This(v8This)
-{
- v8::Context::Scope contextScope(context);
- v8::Local<v8::FunctionTemplate> localTemplate = v8::FunctionTemplate::New(WebCore::V8Proxy::checkNewLegal);
- m_hostTemplate = v8::Persistent<v8::FunctionTemplate>::New(localTemplate);
- m_hostTemplate->SetClassName(v8::String::New(objectName));
-}
-
-BoundObject::~BoundObject()
-{
- m_hostTemplate.Dispose();
-}
-
-void BoundObject::addProtoFunction(const char* name, v8::InvocationCallback callback)
-{
- v8::Context::Scope contextScope(m_context);
- v8::Local<v8::Signature> signature = v8::Signature::New(m_hostTemplate);
- v8::Local<v8::ObjectTemplate> proto = m_hostTemplate->PrototypeTemplate();
- v8::Local<v8::External> v8This = v8::External::New(m_v8This);
- proto->Set(
- v8::String::New(name),
- v8::FunctionTemplate::New(
- callback,
- v8This,
- signature),
- static_cast<v8::PropertyAttribute>(v8::DontDelete));
-}
-
-void BoundObject::build()
-{
- v8::Context::Scope contextScope(m_context);
- v8::Local<v8::Function> constructor = m_hostTemplate->GetFunction();
- v8::Local<v8::Object> boundObject = WebCore::SafeAllocation::newInstance(constructor);
-
- v8::Handle<v8::Object> global = m_context->Global();
- global->Set(v8::String::New(m_objectName), boundObject);
-}
-
-} // namespace WebKit
Deleted: trunk/Source/WebKit/chromium/src/BoundObject.h (107676 => 107677)
--- trunk/Source/WebKit/chromium/src/BoundObject.h 2012-02-14 07:48:45 UTC (rev 107676)
+++ trunk/Source/WebKit/chromium/src/BoundObject.h 2012-02-14 07:54:48 UTC (rev 107677)
@@ -1,61 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef BoundObject_h
-#define BoundObject_h
-
-#include <v8.h>
-#include <wtf/Noncopyable.h>
-
-namespace WebKit {
-
-// BoundObject is a helper class that lets you map _javascript_ method calls
-// directly to C++ method calls. It should be destroyed once JS object is
-// built.
-class BoundObject {
- WTF_MAKE_NONCOPYABLE(BoundObject);
-public:
- BoundObject(v8::Handle<v8::Context> context, void* v8This, const char* objectName);
- virtual ~BoundObject();
-
- void addProtoFunction(const char* name, v8::InvocationCallback callback);
- void build();
-
-private:
- v8::HandleScope m_handleScope;
- const char* m_objectName;
- v8::Handle<v8::Context> m_context;
- v8::Persistent<v8::FunctionTemplate> m_hostTemplate;
- void* m_v8This;
-};
-
-} // namespace WebKit
-
-#endif
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsFrontendImpl.cpp (107676 => 107677)
--- trunk/Source/WebKit/chromium/src/WebDevToolsFrontendImpl.cpp 2012-02-14 07:48:45 UTC (rev 107676)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsFrontendImpl.cpp 2012-02-14 07:54:48 UTC (rev 107677)
@@ -31,7 +31,6 @@
#include "config.h"
#include "WebDevToolsFrontendImpl.h"
-#include "BoundObject.h"
#include "ContextMenuController.h"
#include "ContextMenuItem.h"
#include "DOMWindow.h"
