Title: [107681] trunk
- Revision
- 107681
- Author
- pfeld...@chromium.org
- Date
- 2012-02-14 00:24:05 -0800 (Tue, 14 Feb 2012)
Log Message
Web Inspector: [REGRESSION] Copy Stack Trace is broken
https://bugs.webkit.org/show_bug.cgi?id=78583
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/copy-stack-trace.html
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
LayoutTests:
* inspector/debugger/copy-stack-trace-expected.txt: Added.
* inspector/debugger/copy-stack-trace.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (107680 => 107681)
--- trunk/LayoutTests/ChangeLog 2012-02-14 08:17:53 UTC (rev 107680)
+++ trunk/LayoutTests/ChangeLog 2012-02-14 08:24:05 UTC (rev 107681)
@@ -1,3 +1,13 @@
+2012-02-14 Pavel Feldman <pfeld...@chromium.org>
+
+ Web Inspector: [REGRESSION] Copy Stack Trace is broken
+ https://bugs.webkit.org/show_bug.cgi?id=78583
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/debugger/copy-stack-trace-expected.txt: Added.
+ * inspector/debugger/copy-stack-trace.html: Added.
+
2012-02-14 Noel Gordon <noel.gor...@gmail.com>
[chromium] Rebaseline JPEG image results after r107389
Added: trunk/LayoutTests/inspector/debugger/copy-stack-trace-expected.txt (0 => 107681)
--- trunk/LayoutTests/inspector/debugger/copy-stack-trace-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/debugger/copy-stack-trace-expected.txt 2012-02-14 08:24:05 UTC (rev 107681)
@@ -0,0 +1,12 @@
+Tests that debugger will copy valid stack trace upon context menu action.
+
+Debugger was enabled.
+Set timer for test function.
+Script execution paused.
+functionBaz (copy-stack-trace.html:19)
+functionBar (copy-stack-trace.html:14)
+testFunction (copy-stack-trace.html:9)
+
+Script execution resumed.
+Debugger was disabled.
+
Added: trunk/LayoutTests/inspector/debugger/copy-stack-trace.html (0 => 107681)
--- trunk/LayoutTests/inspector/debugger/copy-stack-trace.html (rev 0)
+++ trunk/LayoutTests/inspector/debugger/copy-stack-trace.html 2012-02-14 08:24:05 UTC (rev 107681)
@@ -0,0 +1,48 @@
+<html>
+<head>
+<script src=""
+<script src=""
+<script>
+
+function testFunction()
+{
+ functionBar();
+}
+
+function functionBar()
+{
+ functionBaz();
+}
+
+function functionBaz()
+{
+ debugger;
+}
+
+var test = function()
+{
+ InspectorTest.startDebuggerTest(step1);
+
+ function step1()
+ {
+ InspectorTest.runTestFunctionAndWaitUntilPaused(step2);
+ }
+
+ function step2()
+ {
+ InspectorFrontendHost.copyText = InspectorTest.addResult.bind(InspectorTest);
+ WebInspector.panels.scripts.sidebarPanes.callstack._copyStackTrace();
+ InspectorTest.completeDebuggerTest();
+ }
+}
+
+</script>
+</head>
+
+<body _onload_="runTest()">
+<p>
+Tests that debugger will copy valid stack trace upon context menu action.
+</p>
+
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (107680 => 107681)
--- trunk/Source/WebCore/ChangeLog 2012-02-14 08:17:53 UTC (rev 107680)
+++ trunk/Source/WebCore/ChangeLog 2012-02-14 08:24:05 UTC (rev 107681)
@@ -1,3 +1,15 @@
+2012-02-14 Pavel Feldman <pfeld...@chromium.org>
+
+ Web Inspector: [REGRESSION] Copy Stack Trace is broken
+ https://bugs.webkit.org/show_bug.cgi?id=78583
+
+ Reviewed by Yury Semikhatsky.
+
+ Test: inspector/debugger/copy-stack-trace.html
+
+ * inspector/front-end/CallStackSidebarPane.js:
+ (WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
+
2012-02-14 Eric Seidel <e...@webkit.org>
Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
Modified: trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js (107680 => 107681)
--- trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2012-02-14 08:17:53 UTC (rev 107680)
+++ trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2012-02-14 08:24:05 UTC (rev 107681)
@@ -126,7 +126,7 @@
{
var text = "";
for (var i = 0; i < this.placards.length; ++i)
- text += this.placards[i]._text + "\n";
+ text += this.placards[i].title + " (" + this.placards[i].subtitle + ")\n";
InspectorFrontendHost.copyText(text);
},
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
