Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (293177 => 293178)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-04-21 17:51:08 UTC (rev 293178)
@@ -1,3 +1,59 @@
+2022-04-21 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: add reference page links for the Timelines Tab
+ https://bugs.webkit.org/show_bug.cgi?id=239580
+
+ Reviewed by Patrick Angle.
+
+ * UserInterface/Views/TimelineView.js:
+ (WI.TimelineView.prototype.initialLayout): Added.
+ * UserInterface/Views/TimelineView.css:
+ (.timeline-view > .reference-page-link-container): Added.
+ Add a reference page link to the bottom-right of each timeline view.
+
+ * UserInterface/Views/CPUTimelineView.js:
+ (WI.CPUTimelineView.prototype.initialLayout):
+ * UserInterface/Views/HeapAllocationsTimelineView.js:
+ * UserInterface/Views/LayoutTimelineView.js:
+ * UserInterface/Views/MediaTimelineView.js:
+ * UserInterface/Views/MemoryTimelineView.js:
+ * UserInterface/Views/NetworkTimelineView.js:
+ * UserInterface/Views/OverviewTimelineView.js:
+ * UserInterface/Views/RenderingFrameTimelineView.js:
+ * UserInterface/Views/ScriptDetailsTimelineView.js:
+ * UserInterface/Views/ScriptProfileTimelineView.js:
+ Add `WI.*.ReferencePage = WI.ReferencePage.*` relationships for each timeline view.
+
+ * UserInterface/Base/ReferencePage.js:
+ (WI.ReferencePage): Added.
+ (WI.ReferencePage.prototype.get page): Added.
+ (WI.ReferencePage.prototype.get topic): Added.
+ (WI.ReferencePage.prototype.createLinkElement): Added.
+ * UserInterface/Base/Main.js:
+ (WI.createReferencePageLink): Moved to `WI.ReferencePage.prototype.createLinkElement`.
+ Create a `WI.ReferencePage` class that knows how to generate a `<a>`.
+
+ * UserInterface/Views/AuditNavigationSidebarPanel.js:
+ (WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
+ * UserInterface/Views/AuditTestCaseContentView.js:
+ (WI.AuditTestCaseContentView.prototype.showRunningPlaceholder):
+ * UserInterface/Views/AuditTestContentView.js:
+ (WI.AuditTestContentView.prototype.showStoppingPlaceholder):
+ (WI.AuditTestContentView.prototype.showNoResultPlaceholder):
+ (WI.AuditTestContentView.prototype.showNoResultDataPlaceholder):
+ (WI.AuditTestContentView.prototype.showFilteredPlaceholder):
+ * UserInterface/Views/AuditTestGroupContentView.js:
+ (WI.AuditTestGroupContentView.prototype.showRunningPlaceholder):
+ * UserInterface/Views/BreakpointPopover.js:
+ (WI.BreakpointPopover.prototype.show):
+ * UserInterface/Views/CreateAuditPopover.js:
+ (WI.CreateAuditPopover.prototype.show):
+ * UserInterface/Views/Layers3DContentView.js:
+ (WI.Layers3DContentView.prototype.initialLayout):
+ * UserInterface/Views/LocalResourceOverridePopover.js:
+ (WI.LocalResourceOverridePopover.prototype.show):
+ Replace `WI.createReferencePageLink` with `WI.ReferencePage.*.createLinkElement`
+
2022-04-18 Elliott Williams <e...@apple.com>
[XCBuild] Use XCBuild for all command-line and project builds
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -2451,7 +2451,7 @@
}
}
- contentElement.appendChild(WI.createReferencePageLink("device-settings"));
+ contentElement.appendChild(WI.ReferencePage.DeviceSettings.createLinkElement());
WI._deviceSettingsPopover.presentNewContentWithFrame(contentElement, calculateTargetFrame(), preferredEdges);
};
@@ -3111,23 +3111,6 @@
return containerElement;
};
-WI.createReferencePageLink = function(page, fragment)
-{
- let url = "" + page + "/";
- if (fragment)
- url += "#" + fragment;
-
- let wrapper = document.createElement("span");
- wrapper.className = "reference-page-link-container";
-
- let link = wrapper.appendChild(document.createElement("a"));
- link.className = "reference-page-link";
- link.href = "" = url;
- link.textContent = "?";
-
- return wrapper;
-};
-
WI.createGoToArrowButton = function()
{
var button = document.createElement("button");
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/ReferencePage.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Base/ReferencePage.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/ReferencePage.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2022 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -23,10 +23,77 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-WI.ReferencePage = {
- DOMBreakpoints: "dom-breakpoints",
- EventBreakpoints: "event-breakpoints",
- _javascript_Breakpoints: "_javascript_-breakpoints",
- LocalOverrides: "local-overrides",
- URLBreakpoints: "url-breakpoints",
+WI.ReferencePage = class ReferencePage {
+ constructor(page, {topic} = {})
+ {
+ console.assert(page instanceof WI.ReferencePage || typeof page === "string", page);
+ console.assert(!(page instanceof WI.ReferencePage && page._page instanceof WI.ReferencePage), page);
+ console.assert(!(page instanceof WI.ReferencePage && page.topic), page);
+ console.assert(!topic || typeof topic === "string", topic);
+
+ if (page instanceof WI.ReferencePage)
+ page = page.page;
+ this._page = page;
+
+ this._topic = topic || "";
+ }
+
+ // Public
+
+ get page() { return this._page; }
+ get topic() { return this._topic; }
+
+ createLinkElement()
+ {
+ let url = "" + this._page + "/";
+ if (this._topic)
+ url += "#" + this._topic;
+
+ let wrapper = document.createElement("span");
+ wrapper.className = "reference-page-link-container";
+
+ let link = wrapper.appendChild(document.createElement("a"));
+ link.className = "reference-page-link";
+ link.href = "" = url;
+ link.textContent = "?";
+
+ return wrapper;
+ }
};
+
+WI.ReferencePage.AuditTab = new WI.ReferencePage("audit-tab");
+WI.ReferencePage.AuditTab.AuditResults = new WI.ReferencePage(WI.ReferencePage.AuditTab, {topic: "audit-results"});
+WI.ReferencePage.AuditTab.CreatingAudits = new WI.ReferencePage(WI.ReferencePage.AuditTab, {topic: "creating-audits"});
+WI.ReferencePage.AuditTab.EditingAudits = new WI.ReferencePage(WI.ReferencePage.AuditTab, {topic: "editing-audits"});
+WI.ReferencePage.AuditTab.RunningAudits = new WI.ReferencePage(WI.ReferencePage.AuditTab, {topic: "running-audits"});
+
+WI.ReferencePage.DOMBreakpoints = new WI.ReferencePage("dom-breakpoints");
+WI.ReferencePage.DOMBreakpoints.Configuration = new WI.ReferencePage(WI.ReferencePage.DOMBreakpoints, {topic: "configuration"});
+
+WI.ReferencePage.DeviceSettings = new WI.ReferencePage("device-settings");
+WI.ReferencePage.DeviceSettings.Configuration = new WI.ReferencePage(WI.ReferencePage.DeviceSettings, {topic: "configuration"});
+
+WI.ReferencePage.EventBreakpoints = new WI.ReferencePage("event-breakpoints");
+WI.ReferencePage.EventBreakpoints.Configuration = new WI.ReferencePage(WI.ReferencePage.EventBreakpoints, {topic: "configuration"});
+
+WI.ReferencePage._javascript_Breakpoints = new WI.ReferencePage("_javascript_-breakpoints");
+WI.ReferencePage._javascript_Breakpoints.Configuration = new WI.ReferencePage(WI.ReferencePage._javascript_Breakpoints, {topic: "configuration"});
+
+WI.ReferencePage.LayersTab = new WI.ReferencePage("layers-tab");
+
+WI.ReferencePage.LocalOverrides = new WI.ReferencePage("local-overrides");
+WI.ReferencePage.LocalOverrides.ConfiguringLocalOverrides = new WI.ReferencePage(WI.ReferencePage.LocalOverrides, {topic: "configuring-local-overrides"});
+
+WI.ReferencePage.TimelinesTab = new WI.ReferencePage("timelines-tab");
+WI.ReferencePage.TimelinesTab.CPUTimeline = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "cpu-timeline"});
+WI.ReferencePage.TimelinesTab.EventsView = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "events-view"});
+WI.ReferencePage.TimelinesTab.FramesView = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "frames-view"});
+WI.ReferencePage.TimelinesTab._javascript_AllocationsTimeline = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "_javascript_-allocations-timeline"});
+WI.ReferencePage.TimelinesTab._javascript_AndEventsTimeline = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "_javascript_-events-timeline"});
+WI.ReferencePage.TimelinesTab.LayoutAndRenderingTimeline = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "layout-rendering-timeline"});
+WI.ReferencePage.TimelinesTab.MediaAndAnimationsTimeline = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "media-animations-timeline"});
+WI.ReferencePage.TimelinesTab.MemoryTimeline = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "memory-timeline"});
+WI.ReferencePage.TimelinesTab.NetworkRequestsTimeline = new WI.ReferencePage(WI.ReferencePage.TimelinesTab, {topic: "network-timeline"});
+
+WI.ReferencePage.URLBreakpoints = new WI.ReferencePage("url-breakpoints");
+WI.ReferencePage.URLBreakpoints.Configuration = new WI.ReferencePage(WI.ReferencePage.URLBreakpoints, {topic: "configuration"});
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -102,7 +102,7 @@
version = Math.min(version, InspectorBackend.getVersion("Audit"));
versionContainer.textContent = WI.UIString("Audit version: %s").format(version);
- versionContainer.appendChild(WI.createReferencePageLink("audit-tab"));
+ versionContainer.appendChild(WI.auditManager.editing ? WI.ReferencePage.AuditTab.EditingAudits.createLinkElement() : WI.ReferencePage.AuditTab.createLinkElement());
this.contentBrowser.showContentView(contentView);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -346,7 +346,7 @@
let stopAuditHelpElement = WI.createNavigationItemHelp(WI.UIString("Press %s to stop running."), stopAuditNavigationItem);
this.placeholderElement.appendChild(stopAuditHelpElement);
- this.placeholderElement.appendChild(WI.createReferencePageLink("audit-tab"));
+ this.placeholderElement.appendChild(WI.ReferencePage.AuditTab.RunningAudits.createLinkElement());
}
super.showRunningPlaceholder();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -339,7 +339,7 @@
let spinner = new WI.IndeterminateProgressSpinner;
this.placeholderElement.appendChild(spinner.element);
- this.placeholderElement.appendChild(WI.createReferencePageLink("audit-tab"));
+ this.placeholderElement.appendChild(WI.ReferencePage.AuditTab.RunningAudits.createLinkElement());
}
this._showPlaceholder();
@@ -360,7 +360,7 @@
let importHelpElement = WI.createNavigationItemHelp(WI.UIString("Press %s to start running the audit."), startNavigationItem);
this.placeholderElement.appendChild(importHelpElement);
- this.placeholderElement.appendChild(WI.createReferencePageLink("audit-tab"));
+ this.placeholderElement.appendChild(WI.ReferencePage.AuditTab.RunningAudits.createLinkElement());
}
this._showPlaceholder();
@@ -394,7 +394,7 @@
this.placeholderElement = WI.createMessageTextView(message.format(this.representedObject.name), result.didError);
this.placeholderElement.__placeholderNoResultData = true;
- this.placeholderElement.appendChild(WI.createReferencePageLink("audit-tab"));
+ this.placeholderElement.appendChild(WI.ReferencePage.AuditTab.AuditResults.createLinkElement());
}
this._showPlaceholder();
@@ -413,7 +413,7 @@
this.needsLayout();
});
- this.placeholderElement.appendChild(WI.createReferencePageLink("audit-tab"));
+ this.placeholderElement.appendChild(WI.ReferencePage.AuditTab.createLinkElement());
}
this._showPlaceholder();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -267,7 +267,7 @@
let stopAuditHelpElement = WI.createNavigationItemHelp(WI.UIString("Press %s to stop running."), stopAuditNavigationItem);
this.placeholderElement.appendChild(stopAuditHelpElement);
- this.placeholderElement.appendChild(WI.createReferencePageLink("audit-tab"));
+ this.placeholderElement.appendChild(WI.ReferencePage.AuditTab.RunningAudits.createLinkElement());
}
super.showRunningPlaceholder();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopover.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopover.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopover.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -247,7 +247,10 @@
});
}
- this._contentElement.appendChild(WI.createReferencePageLink(this._breakpoint?.constructor.ReferencePage || this.constructor.ReferencePage, this._breakpoint ? "configuration" : ""));
+ let referencePage = this._breakpoint?.constructor.ReferencePage || this.constructor.ReferencePage;
+ if (this._breakpoint)
+ referencePage = referencePage.Configuration;
+ this._contentElement.appendChild(referencePage.createLinkElement());
this.content = this._contentElement;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -156,6 +156,8 @@
initialLayout()
{
+ super.initialLayout();
+
this.element.style.setProperty("--cpu-usage-combined-view-height", CPUTimelineView.cpuUsageViewHeight + "px");
this.element.style.setProperty("--cpu-usage-view-height", CPUTimelineView.threadCPUUsageViewHeight + "px");
this.element.style.setProperty("--cpu-usage-indicator-view-height", CPUTimelineView.indicatorViewHeight + "px");
@@ -1821,3 +1823,5 @@
Paint: "sample-type-paint",
Style: "sample-type-style",
};
+
+WI.CPUTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab.CPUTimeline;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CreateAuditPopover.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CreateAuditPopover.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CreateAuditPopover.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -77,7 +77,7 @@
}
});
- editorWrapper.appendChild(WI.createReferencePageLink("audit-tab", "creating-audits"));
+ editorWrapper.appendChild(WI.ReferencePage.AuditTab.CreatingAudits.createLinkElement());
this.content = contentElement;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -523,3 +523,5 @@
this._updateUnseenRecordsBannerView();
}
};
+
+WI.HeapAllocationsTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab._javascript_AllocationsTimeline;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -175,7 +175,7 @@
this.element.appendChild(this._renderer.domElement);
- this.element.appendChild(WI.createReferencePageLink("layers-tab"));
+ this.element.appendChild(WI.ReferencePage.LayersTab.createLinkElement());
this._animate();
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -339,3 +339,5 @@
this._updateHighlight();
}
};
+
+WI.LayoutTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab.LayoutAndRenderingTimeline;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -411,7 +411,7 @@
skipNetworkLabel.appendChild(document.createTextNode(WI.UIString("Skip Network", "Skip Network @ Local Override Popover Options", "Label for checkbox that controls whether the local override will actually perform a network request or skip it to immediately serve the response.")));
}
- popoverContentElement.appendChild(WI.createReferencePageLink(WI.ReferencePage.LocalOverrides, "configuring-local-overrides"));
+ popoverContentElement.appendChild(WI.ReferencePage.LocalOverrides.ConfiguringLocalOverrides.createLinkElement());
let incrementStatusCode = () => {
let x = parseInt(this._statusCodeCodeMirror.getValue());
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/MediaTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/MediaTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/MediaTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -201,3 +201,5 @@
dataGridNode.revealAndSelect();
}
};
+
+WI.MediaTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab.MediaAndAnimationsTimeline;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -467,3 +467,5 @@
this._maxSize = Math.max(this._maxSize, memoryTimelineRecord.totalSize);
}
};
+
+WI.MemoryTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab.MemoryTimeline;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -274,3 +274,5 @@
this._pendingRecords.push(resourceTimelineRecord);
}
};
+
+WI.NetworkTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab.NetworkRequestsTimeline;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -443,3 +443,5 @@
this._timelineRuler.addMarker(this._currentTimeMarker);
}
};
+
+WI.OverviewTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab.EventsView;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -299,3 +299,4 @@
OverFifteenMilliseconds: "rendering-frame-timeline-view-duration-filter-over-15-ms"
};
+WI.RenderingFrameTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab.FramesView;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -227,3 +227,5 @@
this.needsLayout();
}
};
+
+WI.ScriptDetailsTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab._javascript_AndEventsTimeline;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptProfileTimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptProfileTimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptProfileTimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -212,3 +212,5 @@
Hierarchy: "hierarchy",
TopFunctions: "top-functions",
};
+
+WI.ScriptProfileTimelineView.ReferencePage = WI.ReferencePage.TimelinesTab._javascript_AndEventsTimeline;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.css (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.css 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.css 2022-04-21 17:51:08 UTC (rev 293178)
@@ -44,3 +44,9 @@
.panel.navigation.timeline.timeline-recording-content-view-showing > .content > .tree-outline {
background: var(--transparent-stripe-background-gradient);
}
+
+.timeline-view > .reference-page-link-container {
+ position: absolute;
+ bottom: 6px;
+ inset-inline-end: 6px;
+}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js (293177 => 293178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2022-04-21 17:43:30 UTC (rev 293177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2022-04-21 17:51:08 UTC (rev 293178)
@@ -32,6 +32,7 @@
// This class should not be instantiated directly. Create a concrete subclass instead.
console.assert(this.constructor !== WI.TimelineView && this instanceof WI.TimelineView);
+ console.assert(this.constructor.ReferencePage, this);
this.element.classList.add("timeline-view");
@@ -292,6 +293,14 @@
// Protected
+ initialLayout()
+ {
+ super.initialLayout();
+
+ if (this.constructor.ReferencePage)
+ this.element.appendChild(this.constructor.ReferencePage.createLinkElement());
+ }
+
filterDidChange()
{
// Implemented by sub-classes if needed.
