Title: [293207] trunk/Tools
Revision
293207
Author
commit-qu...@webkit.org
Date
2022-04-21 20:56:06 -0700 (Thu, 21 Apr 2022)

Log Message

[PGO] Fix perl warnings cause by PGO for real this time.
https://bugs.webkit.org/show_bug.cgi?id=239633

Reviewed by Yusuke Suzuki.

Add a missing 'defined' check before reading the PGO environment variable.

* Tools/Scripts/check-for-weak-vtables-and-externals:

Canonical link: https://commits.webkit.org/249878@main

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (293206 => 293207)


--- trunk/Tools/ChangeLog	2022-04-22 03:27:11 UTC (rev 293206)
+++ trunk/Tools/ChangeLog	2022-04-22 03:56:06 UTC (rev 293207)
@@ -1,3 +1,14 @@
+2022-04-21  Justin Michaud  <justin_mich...@apple.com>
+
+        [PGO] Fix perl warnings cause by PGO for real this time
+        https://bugs.webkit.org/show_bug.cgi?id=239633
+
+        Reviewed by Yusuke Suzuki.
+
+        Add a missing 'defined' check before reading the PGO environment variable.
+
+        * Scripts/check-for-weak-vtables-and-externals:
+
 2022-04-20  Yusuke Suzuki  <ysuz...@apple.com>
 
         [WTF] Add string concatenate adapter for UUID

Modified: trunk/Tools/Scripts/check-for-weak-vtables-and-externals (293206 => 293207)


--- trunk/Tools/Scripts/check-for-weak-vtables-and-externals	2022-04-22 03:27:11 UTC (rev 293206)
+++ trunk/Tools/Scripts/check-for-weak-vtables-and-externals	2022-04-22 03:56:06 UTC (rev 293207)
@@ -60,7 +60,10 @@
     }
     my @weakVTableClasses = ();
     my @weakExternalSymbols = ();
-    my $skipProfileSymbols = coverageIsEnabled() || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ON" || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ENABLE_LLVM_PROFILE_GENERATION";
+    my $skipProfileSymbols = coverageIsEnabled();
+    if (defined $ENV{'ENABLE_LLVM_PROFILE_GENERATION'}) {
+        $skipProfileSymbols ||= $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ON" || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ENABLE_LLVM_PROFILE_GENERATION";
+    }
     while (<NM>) {
         if (/^STDOUT:/) {
             # Ignore undefined, RTTI and typeinfo symbols.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to