Diff
Modified: trunk/LayoutTests/ChangeLog (293523 => 293524)
--- trunk/LayoutTests/ChangeLog 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/ChangeLog 2022-04-27 19:04:59 UTC (rev 293524)
@@ -1,3 +1,24 @@
+2022-04-27 Tim Nguyen <n...@apple.com>
+
+ Make -webkit-transform-style an alias of transform-style
+ https://bugs.webkit.org/show_bug.cgi?id=239808
+
+ Reviewed by Antti Koivisto.
+
+ Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
+ unnecessary code as well given the FIXME was never addressed.
+
+ * fast/css/getComputedStyle/computed-style-expected.txt:
+ * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+ * platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+ * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+ * platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
+ * platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+ * svg/css/getComputedStyle-basic-expected.txt:
+
2022-04-27 Arcady Goldmints-Orlov <agoldmi...@igalia.com>
[GTK] The setting WebKitMinimumFontSize is not reset by the testing framework, leading to flaky tests
Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (293523 => 293524)
--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -253,7 +253,6 @@
-webkit-text-security: none;
-webkit-text-stroke-color: rgb(0, 0, 0);
-webkit-text-stroke-width: 0px;
--webkit-transform-style: flat;
-webkit-user-drag: auto;
-webkit-user-modify: read-only;
Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (293523 => 293524)
--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -252,7 +252,6 @@
-webkit-text-security: none
-webkit-text-stroke-color: rgb(0, 0, 0)
-webkit-text-stroke-width: 0px
--webkit-transform-style: flat
-webkit-user-drag: auto
-webkit-user-modify: read-only
background-position-x: 0%
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293523 => 293524)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-27 19:04:59 UTC (rev 293524)
@@ -1,5 +1,19 @@
2022-04-27 Tim Nguyen <n...@apple.com>
+ Make -webkit-transform-style an alias of transform-style
+ https://bugs.webkit.org/show_bug.cgi?id=239808
+
+ Reviewed by Antti Koivisto.
+
+ Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
+ unnecessary code as well given the FIXME was never addressed.
+
+ * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
+ * web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+
+2022-04-27 Tim Nguyen <n...@apple.com>
+
[css-text] Make word-wrap CSS property an alias of overflow-wrap
https://bugs.webkit.org/show_bug.cgi?id=166782
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293523 => 293524)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -398,7 +398,6 @@
PASS -webkit-text-stroke-color
PASS -webkit-text-stroke-width
PASS -webkit-text-zoom
-PASS -webkit-transform-style
PASS -webkit-user-drag
PASS -webkit-user-modify
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt (293523 => 293524)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -310,7 +310,7 @@
FAIL transform-origin-x assert_not_equals: Should have the initial value. got disallowed value ""
FAIL transform-origin-y assert_not_equals: Should have the initial value. got disallowed value ""
FAIL transform-origin-z assert_not_equals: Should have the initial value. got disallowed value ""
-FAIL transform-style assert_not_equals: Should get a different computed value. got disallowed value "flat"
+PASS transform-style
PASS transition-delay
PASS transition-duration
PASS transition-property
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (293523 => 293524)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 399
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 399
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 399
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 399
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 398
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 398
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 398
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 398
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293523 => 293524)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -396,7 +396,6 @@
PASS -webkit-text-stroke-color
PASS -webkit-text-stroke-width
PASS -webkit-text-zoom
-PASS -webkit-transform-style
PASS -webkit-user-drag
PASS -webkit-user-modify
Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (293523 => 293524)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 397
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 397
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 397
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 397
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 396
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 396
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 396
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 396
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293523 => 293524)
--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -373,7 +373,6 @@
PASS -webkit-text-stroke-width
PASS -webkit-text-zoom
PASS -webkit-touch-callout
-PASS -webkit-transform-style
PASS -webkit-user-drag
PASS -webkit-user-modify
Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (293523 => 293524)
--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 401
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 401
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 401
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 401
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 400
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 400
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 400
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 400
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt (293523 => 293524)
--- trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -309,7 +309,7 @@
FAIL transform-origin-x assert_not_equals: Should have the initial value. got disallowed value ""
FAIL transform-origin-y assert_not_equals: Should have the initial value. got disallowed value ""
FAIL transform-origin-z assert_not_equals: Should have the initial value. got disallowed value ""
-FAIL transform-style assert_not_equals: Should get a different computed value. got disallowed value "flat"
+PASS transform-style
PASS transition-delay
PASS transition-duration
PASS transition-property
Modified: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293523 => 293524)
--- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -395,7 +395,6 @@
PASS -webkit-text-stroke-color
PASS -webkit-text-stroke-width
PASS -webkit-text-zoom
-PASS -webkit-transform-style
PASS -webkit-user-drag
PASS -webkit-user-modify
Modified: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (293523 => 293524)
--- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 396
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 396
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 396
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 396
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 395
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 395
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 395
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 395
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt (293523 => 293524)
--- trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2022-04-27 19:04:59 UTC (rev 293524)
@@ -504,8 +504,6 @@
rect: style.getPropertyCSSValue(-webkit-text-stroke-color) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(-webkit-text-stroke-width) : 0px
rect: style.getPropertyCSSValue(-webkit-text-stroke-width) : [object CSSPrimitiveValue]
-rect: style.getPropertyValue(-webkit-transform-style) : flat
-rect: style.getPropertyCSSValue(-webkit-transform-style) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(-webkit-user-drag) : auto
rect: style.getPropertyCSSValue(-webkit-user-drag) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(-webkit-user-modify) : read-only
@@ -1016,8 +1014,6 @@
g: style.getPropertyCSSValue(-webkit-text-stroke-color) : [object CSSPrimitiveValue]
g: style.getPropertyValue(-webkit-text-stroke-width) : 0px
g: style.getPropertyCSSValue(-webkit-text-stroke-width) : [object CSSPrimitiveValue]
-g: style.getPropertyValue(-webkit-transform-style) : flat
-g: style.getPropertyCSSValue(-webkit-transform-style) : [object CSSPrimitiveValue]
g: style.getPropertyValue(-webkit-user-drag) : auto
g: style.getPropertyCSSValue(-webkit-user-drag) : [object CSSPrimitiveValue]
g: style.getPropertyValue(-webkit-user-modify) : read-only
Modified: trunk/Source/WebCore/ChangeLog (293523 => 293524)
--- trunk/Source/WebCore/ChangeLog 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/Source/WebCore/ChangeLog 2022-04-27 19:04:59 UTC (rev 293524)
@@ -1,3 +1,24 @@
+2022-04-27 Tim Nguyen <n...@apple.com>
+
+ Make -webkit-transform-style an alias of transform-style
+ https://bugs.webkit.org/show_bug.cgi?id=239808
+
+ Reviewed by Antti Koivisto.
+
+ Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
+ unnecessary code as well given the FIXME was never addressed.
+
+ * animation/CSSPropertyAnimation.cpp:
+ (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
+ * css/CSSProperties.json:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/WillChangeData.cpp:
+ (WebCore::WillChangeData::propertyCreatesStackingContext):
+
2022-04-27 Simon Fraser <simon.fra...@apple.com>
Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (293523 => 293524)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-04-27 19:04:59 UTC (rev 293524)
@@ -3652,7 +3652,6 @@
#if PLATFORM(IOS_FAMILY)
case CSSPropertyWebkitTouchCallout:
#endif
- case CSSPropertyWebkitTransformStyle:
case CSSPropertyWebkitUserDrag:
case CSSPropertyWebkitUserModify:
case CSSPropertyUserSelect:
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (293523 => 293524)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-04-27 19:04:59 UTC (rev 293524)
@@ -3923,7 +3923,6 @@
return list;
}
case CSSPropertyTransformStyle:
- case CSSPropertyWebkitTransformStyle:
switch (style.transformStyle3D()) {
case TransformStyle3D::Flat:
return cssValuePool.createIdentifierValue(CSSValueFlat);
Modified: trunk/Source/WebCore/css/CSSProperties.json (293523 => 293524)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-04-27 19:04:59 UTC (rev 293524)
@@ -7219,6 +7219,9 @@
}
],
"codegen-properties": {
+ "aliases": [
+ "-webkit-transform-style"
+ ],
"name-for-methods": "TransformStyle3D"
},
"specification": {
@@ -7226,20 +7229,6 @@
"url": "https://www.w3.org/TR/css-transforms-1/#transform-style-property"
}
},
- "-webkit-transform-style": {
- "values": [
- "flat",
- "preserve-3d",
- {
- "value": "optimized-3d",
- "status": "internal"
- }
- ],
- "codegen-properties": {
- "name-for-methods": "TransformStyle3D",
- "comment": "Keeping -webkit-transform-style around is how we'll detect legacy content. At that point, we'll have to add a custom builder and a new TransformStyle3D type. FIXME: this never happened."
- }
- },
"translate": {
"codegen-properties": {
"settings-flag": "cssIndividualTransformPropertiesEnabled",
Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (293523 => 293524)
--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-04-27 19:04:59 UTC (rev 293524)
@@ -814,7 +814,6 @@
case CSSPropertyWebkitTextSecurity: // disc | circle | square | none
return valueID == CSSValueDisc || valueID == CSSValueCircle || valueID == CSSValueSquare || valueID == CSSValueNone;
case CSSPropertyTransformStyle:
- case CSSPropertyWebkitTransformStyle:
return valueID == CSSValueFlat
|| valueID == CSSValuePreserve3d
#if ENABLE(CSS_TRANSFORM_STYLE_OPTIMIZED_3D)
@@ -986,7 +985,6 @@
case CSSPropertyTextDecorationStyle:
case CSSPropertyWebkitTextSecurity:
case CSSPropertyWebkitTextZoom:
- case CSSPropertyWebkitTransformStyle:
case CSSPropertyWebkitUserDrag:
case CSSPropertyWebkitUserModify:
case CSSPropertyUserSelect:
Modified: trunk/Source/WebCore/rendering/style/WillChangeData.cpp (293523 => 293524)
--- trunk/Source/WebCore/rendering/style/WillChangeData.cpp 2022-04-27 19:03:10 UTC (rev 293523)
+++ trunk/Source/WebCore/rendering/style/WillChangeData.cpp 2022-04-27 19:04:59 UTC (rev 293524)
@@ -95,7 +95,6 @@
case CSSPropertyTranslate:
case CSSPropertyTransform:
case CSSPropertyTransformStyle:
- case CSSPropertyWebkitTransformStyle:
case CSSPropertyClipPath:
case CSSPropertyMask:
case CSSPropertyWebkitMask:
