Title: [293541] trunk/Source/WebInspectorUI
- Revision
- 293541
- Author
- commit-qu...@webkit.org
- Date
- 2022-04-27 15:38:00 -0700 (Wed, 27 Apr 2022)
Log Message
Web Inspector: Improve rendering of GLenums in WebGL canvas recordings.
https://bugs.webkit.org/show_bug.cgi?id=239586
Patch by Dan Glastonbury <d...@apple.com> on 2022-04-27
Reviewed by Devin Rousso.
* Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.constantNameForParameter):
Arrays are also objects, so checking for typeof x == "object" is
not enough to distinguish arrays from dictionaries. Since the if
above the failing check was handling arrays, turn "object" check
into an `else if` handles arrays and dictionaries correctly.
Canonical link: https://commits.webkit.org/250062@main
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (293540 => 293541)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-04-27 22:31:21 UTC (rev 293540)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-04-27 22:38:00 UTC (rev 293541)
@@ -1,3 +1,17 @@
+2022-04-20 Dan Glastonbury <d...@apple.com>
+
+ Web Inspector: Improve rendering of GLenums in WebGL canvas recordings.
+ https://bugs.webkit.org/show_bug.cgi?id=239586
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Models/RecordingAction.js:
+ (WI.RecordingAction.constantNameForParameter):
+ Arrays are also objects, so checking for typeof x == "object" is
+ not enough to distinguish arrays from dictionaries. Since the if
+ above the failing check was handling arrays, turn "object" check
+ into an `else if` handles arrays and dictionaries correctly.
+
2022-04-27 Ziran Sun <z...@igalia.com>
[css-ui] Remove some unimplemented -webkit-appearance keywords
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js (293540 => 293541)
--- trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js 2022-04-27 22:31:21 UTC (rev 293540)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js 2022-04-27 22:38:00 UTC (rev 293541)
@@ -125,10 +125,10 @@
if (!indexesForAction)
return null;
- if (Array.isArray(indexesForAction) && !indexesForAction.includes(index))
- return null;
-
- if (typeof indexesForAction === "object") {
+ if (Array.isArray(indexesForAction)) {
+ if (!indexesForAction.includes(index))
+ return null;
+ } else if (typeof indexesForAction === "object") {
let indexesForActionVariant = indexesForAction[count];
if (!indexesForActionVariant)
return null;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
