Title: [294118] trunk/Source/WebCore
- Revision
- 294118
- Author
- bfulg...@apple.com
- Date
- 2022-05-12 13:58:18 -0700 (Thu, 12 May 2022)
Log Message
REGRESSION (r281791): [iOS] WKWebView cannot load local .log file
https://bugs.webkit.org/show_bug.cgi?id=239591
<rdar://problem/92442408>
Reviewed by Geoffrey Garen.
The refactoring in Bug 229414 did not retain the old behavior on iOS where local
files (which do not get a MIME type assigned by CFNetwork) passed through the
same 'preferredMIMETypeForFileExtensionFromUTType' logic we use on macOS.
* platform/network/ios/WebCoreURLResponseIOS.mm:
(WebCore::adjustMIMETypeIfNecessary):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (294117 => 294118)
--- trunk/Source/WebCore/ChangeLog 2022-05-12 20:15:42 UTC (rev 294117)
+++ trunk/Source/WebCore/ChangeLog 2022-05-12 20:58:18 UTC (rev 294118)
@@ -1,3 +1,18 @@
+2022-05-12 Brent Fulgham <bfulg...@apple.com>
+
+ REGRESSION (r281791): [iOS] WKWebView cannot load local .log file
+ https://bugs.webkit.org/show_bug.cgi?id=239591
+ <rdar://problem/92442408>
+
+ Reviewed by Geoffrey Garen.
+
+ The refactoring in Bug 229414 did not retain the old behavior on iOS where local
+ files (which do not get a MIME type assigned by CFNetwork) passed through the
+ same 'preferredMIMETypeForFileExtensionFromUTType' logic we use on macOS.
+
+ * platform/network/ios/WebCoreURLResponseIOS.mm:
+ (WebCore::adjustMIMETypeIfNecessary):
+
2022-05-12 Alex Christensen <achristen...@webkit.org>
Make if-domain and unless-domain regexes only look at URL hosts
Modified: trunk/Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm (294117 => 294118)
--- trunk/Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm 2022-05-12 20:15:42 UTC (rev 294117)
+++ trunk/Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm 2022-05-12 20:58:18 UTC (rev 294118)
@@ -49,8 +49,6 @@
return;
}
}
- CFURLResponseSetMIMEType(response, CFSTR("application/octet-stream"));
- return;
}
#if !USE(QUICK_LOOK)
@@ -67,8 +65,11 @@
updatedType = preferredMIMETypeForFileExtensionFromUTType(extension.get());
if (updatedType && (!type || CFStringCompare(type, updatedType.get(), kCFCompareCaseInsensitive) != kCFCompareEqualTo))
CFURLResponseSetMIMEType(response, updatedType.get());
+ return;
}
#endif // USE(QUICK_LOOK)
+ if (!type)
+ CFURLResponseSetMIMEType(response, CFSTR("application/octet-stream"));
}
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
