Title: [294579] trunk/Source
- Revision
- 294579
- Author
- commit-qu...@webkit.org
- Date
- 2022-05-20 14:21:54 -0700 (Fri, 20 May 2022)
Log Message
[web-animations] provide a dedicated flag for KeyframeEffect.iterationComposite
https://bugs.webkit.org/show_bug.cgi?id=240727
Patch by Antoine Quint <grao...@apple.com> on 2022-05-20
Reviewed by Dean Jackson.
Add a dedicated flag for the `KeyframeEffect.iterationComposite` property as
that property did not make it to Web Animations 1.0 and should not be enabled
together with `KeyframeEffect.composite`.
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create):
* Source/WebCore/animation/KeyframeEffect.idl:
Canonical link: https://commits.webkit.org/250816@main
Modified Paths
Diff
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (294578 => 294579)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-05-20 21:13:28 UTC (rev 294578)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-05-20 21:21:54 UTC (rev 294579)
@@ -1576,6 +1576,18 @@
WebCore:
default: false
+WebAnimationsIterationCompositeEnabled:
+ type: bool
+ humanReadableName: "Web Animations iteration composite"
+ humanReadableDescription: "Support for the KeyframeEffect.iterationComposite property"
+ defaultValue:
+ WebKitLegacy:
+ default: false
+ WebKit:
+ default: false
+ WebCore:
+ default: false
+
WebAnimationsMutableTimelinesEnabled:
type: bool
humanReadableName: "Web Animations mutable timelines"
Modified: trunk/Source/WebCore/animation/KeyframeEffect.cpp (294578 => 294579)
--- trunk/Source/WebCore/animation/KeyframeEffect.cpp 2022-05-20 21:13:28 UTC (rev 294578)
+++ trunk/Source/WebCore/animation/KeyframeEffect.cpp 2022-05-20 21:21:54 UTC (rev 294579)
@@ -519,7 +519,7 @@
keyframeEffectOptions.direction
};
- if (document.settings().webAnimationsCompositeOperationsEnabled()) {
+ if (document.settings().webAnimationsIterationCompositeEnabled()) {
keyframeEffect->setComposite(keyframeEffectOptions.composite);
keyframeEffect->setIterationComposite(keyframeEffectOptions.iterationComposite);
}
Modified: trunk/Source/WebCore/animation/KeyframeEffect.idl (294578 => 294579)
--- trunk/Source/WebCore/animation/KeyframeEffect.idl 2022-05-20 21:13:28 UTC (rev 294578)
+++ trunk/Source/WebCore/animation/KeyframeEffect.idl 2022-05-20 21:21:54 UTC (rev 294579)
@@ -34,7 +34,7 @@
attribute Element? target;
attribute CSSOMString? pseudoElement;
- [EnabledBySetting=WebAnimationsCompositeOperationsEnabled] attribute IterationCompositeOperation iterationComposite;
+ [EnabledBySetting=WebAnimationsIterationCompositeEnabled] attribute IterationCompositeOperation iterationComposite;
[EnabledBySetting=WebAnimationsCompositeOperationsEnabled, ImplementedAs=bindingsComposite] attribute CompositeOperation composite;
[Custom] sequence<object> getKeyframes();
[CallWith=CurrentGlobalObject&CurrentDocument, ImplementedAs=setBindingsKeyframes] undefined setKeyframes(object? keyframes);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
