Title: [294841] branches/safari-613-branch/Source/WebCore
- Revision
- 294841
- Author
- alanc...@apple.com
- Date
- 2022-05-25 16:49:44 -0700 (Wed, 25 May 2022)
Log Message
Cherry-pick r293827. rdar://problem/92624773
replaceTrack with different constraints stops sending packets
https://bugs.webkit.org/show_bug.cgi?id=239978
<rdar://problem/92624773>
Reviewed by Eric Carlson.
We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.
Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
Canonical link: https://commits.webkit.org/250300@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (294840 => 294841)
--- branches/safari-613-branch/Source/WebCore/ChangeLog 2022-05-25 23:49:41 UTC (rev 294840)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog 2022-05-25 23:49:44 UTC (rev 294841)
@@ -1,5 +1,44 @@
2022-05-19 Alan Coon <alanc...@apple.com>
+ Cherry-pick r293827. rdar://problem/92624773
+
+ replaceTrack with different constraints stops sending packets
+ https://bugs.webkit.org/show_bug.cgi?id=239978
+ <rdar://problem/92624773>
+
+ Reviewed by Eric Carlson.
+
+ We should always reconfigure the microphone processor even if we are not using it,
+ as VPIO expects that input and output formats should match.
+
+ Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
+ A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
+ so that we can write a regression test.
+
+ * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+
+ Canonical link: https://commits.webkit.org/250300@main
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-05-05 Youenn Fablet <you...@apple.com>
+
+ replaceTrack with different constraints stops sending packets
+ https://bugs.webkit.org/show_bug.cgi?id=239978
+ <rdar://problem/92624773>
+
+ Reviewed by Eric Carlson.
+
+ We should always reconfigure the microphone processor even if we are not using it,
+ as VPIO expects that input and output formats should match.
+
+ Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
+ A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
+ so that we can write a regression test.
+
+ * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+
+2022-05-19 Alan Coon <alanc...@apple.com>
+
Cherry-pick r293819. rdar://problem/93602086
Crash in WindowProxy::setDOMWindow
Modified: branches/safari-613-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (294840 => 294841)
--- branches/safari-613-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2022-05-25 23:49:41 UTC (rev 294840)
+++ branches/safari-613-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2022-05-25 23:49:44 UTC (rev 294841)
@@ -298,9 +298,6 @@
{
ASSERT(isMainThread());
- if (!isProducingMicrophoneSamples())
- return noErr;
-
AURenderCallbackStruct callback = { microphoneCallback, this };
auto err = PAL::AudioUnitSetProperty(m_ioUnit, kAudioOutputUnitProperty_SetInputCallback, kAudioUnitScope_Global, inputBus, &callback, sizeof(callback));
if (err) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
