Title: [295465] releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/RenderBox.h
- Revision
- 295465
- Author
- ape...@igalia.com
- Date
- 2022-06-10 15:13:36 -0700 (Fri, 10 Jun 2022)
Log Message
Merge r295399 - Handle a disconnected view during applyTopLeftLocationOffset
https://bugs.webkit.org/show_bug.cgi?id=241355
<rdar://92432637>
Reviewed by Alan Bujtas.
It appears that we can sometimes end up in a state where the document's
view is disconnected during didLayout, which calls applyTopleftLocationOffset.
This just adds a null check to handle this case for now.
* Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::applyTopLeftLocationOffset const):
Canonical link: https://commits.webkit.org/251405@main
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/RenderBox.h (295464 => 295465)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/RenderBox.h 2022-06-10 21:49:55 UTC (rev 295464)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/RenderBox.h 2022-06-10 22:13:36 UTC (rev 295465)
@@ -597,7 +597,7 @@
void applyTopLeftLocationOffset(LayoutPoint& point) const
{
// This is inlined for speed, since it is used by updateLayerPosition() during scrolling.
- if (!document().view()->hasFlippedBlockRenderers())
+ if (!document().view() || !document().view()->hasFlippedBlockRenderers())
point.move(m_frameRect.x(), m_frameRect.y());
else
applyTopLeftLocationOffsetWithFlipping(point);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes