Title: [295531] trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
- Revision
- 295531
- Author
- an...@apple.com
- Date
- 2022-06-14 11:11:01 -0700 (Tue, 14 Jun 2022)
Log Message
Nullptr crash in RenderLayerCompositor::requiresCompositingLayer
https://bugs.webkit.org/show_bug.cgi?id=241595
<rdar://88854150>
Reviewed by Simon Fraser.
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
Add a null check. In -webkit-box-reflect case it is not clear renderer.layer() can't be null.
Canonical link: https://commits.webkit.org/251536@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (295530 => 295531)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2022-06-14 18:06:06 UTC (rev 295530)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2022-06-14 18:11:01 UTC (rev 295531)
@@ -2599,6 +2599,11 @@
{
auto& renderer = rendererForCompositingTests(layer);
+ if (!renderer.layer()) {
+ ASSERT_NOT_REACHED();
+ return false;
+ }
+
// The root layer always has a compositing layer, but it may not have backing.
return requiresCompositingForTransform(renderer)
|| requiresCompositingForAnimation(renderer)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
