Title: [295541] trunk/Source/WebCore
- Revision
- 295541
- Author
- n...@apple.com
- Date
- 2022-06-14 15:15:59 -0700 (Tue, 14 Jun 2022)
Log Message
Remove redundant text-align-last BuilderCustom functions
https://bugs.webkit.org/show_bug.cgi?id=241607
<rdar://95131415>
Reviewed by Simon Fraser.
They might have been copy pasted from text-align, which needs them for the hasExplicitlySetTextAlign flag, which text-align-last does not have.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInitialTextAlignLast): Deleted.
(WebCore::Style::BuilderCustom::applyValueTextAlignLast): Deleted.
Canonical link: https://commits.webkit.org/251546@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/css/CSSProperties.json (295540 => 295541)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-06-14 22:14:47 UTC (rev 295540)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-06-14 22:15:59 UTC (rev 295541)
@@ -4609,7 +4609,6 @@
],
"codegen-properties": {
"converter": "TextAlignLast",
- "custom": "Initial|Value",
"settings-flag": "cssTextAlignLastEnabled"
},
"specification": {
Modified: trunk/Source/WebCore/style/StyleBuilderCustom.h (295540 => 295541)
--- trunk/Source/WebCore/style/StyleBuilderCustom.h 2022-06-14 22:14:47 UTC (rev 295540)
+++ trunk/Source/WebCore/style/StyleBuilderCustom.h 2022-06-14 22:15:59 UTC (rev 295541)
@@ -139,8 +139,6 @@
// Custom handling of initial + value only.
static void applyInitialTextAlign(BuilderState&);
static void applyValueTextAlign(BuilderState&, CSSValue&);
- static void applyInitialTextAlignLast(BuilderState&);
- static void applyValueTextAlignLast(BuilderState&, CSSValue&);
// Custom handling of value setting only.
static void applyValueBaselineShift(BuilderState&, CSSValue&);
@@ -206,16 +204,6 @@
builderState.style().setHasExplicitlySetTextAlign(true);
}
-inline void BuilderCustom::applyInitialTextAlignLast(BuilderState& builderState)
-{
- builderState.style().setTextAlignLast(RenderStyle::initialTextAlignLast());
-}
-
-inline void BuilderCustom::applyValueTextAlignLast(BuilderState& builderState, CSSValue& value)
-{
- builderState.style().setTextAlignLast(BuilderConverter::convertTextAlignLast(builderState, value));
-}
-
inline void BuilderCustom::resetEffectiveZoom(BuilderState& builderState)
{
// Reset the zoom in effect. This allows the setZoom method to accurately compute a new zoom in effect.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
