Title: [295617] trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
- Revision
- 295617
- Author
- [email protected]
- Date
- 2022-06-16 16:52:58 -0700 (Thu, 16 Jun 2022)
Log Message
[WebAuthn] Stop using decidePolicyForLocalAuthenticator
https://bugs.webkit.org/show_bug.cgi?id=241614
rdar://95066808
Reviewed by Brent Fulgham.
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::makeCredential):
Previously, in the browser ui delegate based flow, consent would be given
for the platform authenticator after selecting it. In the new flow you
must consent to the platform authenticator before getting here, so
decidePolicyForLocalAuthenticator is no longer needed.
Canonical link: https://commits.webkit.org/251622@main
Modified Paths
Diff
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (295616 => 295617)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-06-16 23:37:37 UTC (rev 295616)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-06-16 23:52:58 UTC (rev 295617)
@@ -262,19 +262,7 @@
ASSERT(rawId);
return excludeCredentialIds.contains(base64EncodeToString(rawId->data(), rawId->byteLength()));
})) {
- // Obtain consent per Step 3.1
- auto callback = [weakThis = WeakPtr { *this }] (LocalAuthenticatorPolicy policy) {
- RELEASE_ASSERT(RunLoop::isMain());
- if (!weakThis)
- return;
-
- if (policy == LocalAuthenticatorPolicy::Allow)
- weakThis->receiveException({ InvalidStateError, "At least one credential matches an entry of the excludeCredentials list in the platform attached authenticator."_s }, WebAuthenticationStatus::LAExcludeCredentialsMatched);
- else
- weakThis->receiveException({ NotAllowedError, "This request has been cancelled by the user."_s });
- };
- // Similar to below, consent has already been given.
- observer()->decidePolicyForLocalAuthenticator(WTFMove(callback));
+ receiveException({ InvalidStateError, "At least one credential matches an entry of the excludeCredentials list in the platform attached authenticator."_s }, WebAuthenticationStatus::LAExcludeCredentialsMatched);
return;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
