- Revision
- 107973
- Author
- ser...@webkit.org
- Date
- 2012-02-16 12:56:02 -0800 (Thu, 16 Feb 2012)
Log Message
[soup] Move important SoupSession feature initialization to WebCore
https://bugs.webkit.org/show_bug.cgi?id=68602
Reviewed by Martin Robinson.
Source/WebCore:
Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.
No new tests required as we're just moving stuff from WebKit to
WebCore.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):
Source/WebKit/gtk:
Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.
No new tests required as we're just moving stuff from WebKit to
WebCore.
* webkit/webkitglobals.cpp:
(webkitInit):
Source/WebKit2:
Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.
No new tests required as we're just moving stuff from the
WebProcess to WebCore.
* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (107972 => 107973)
--- trunk/Source/WebCore/ChangeLog 2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebCore/ChangeLog 2012-02-16 20:56:02 UTC (rev 107973)
@@ -1,3 +1,20 @@
+2012-02-16 Sergio Villar Senin <svil...@igalia.com>
+
+ [soup] Move important SoupSession feature initialization to WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=68602
+
+ Reviewed by Martin Robinson.
+
+ Moved content sniffer and decoder initialization from WebKit to
+ WebCore because network stuff will not work as expected without
+ them. Added also out-of-the-box proxy support to WebCore.
+
+ No new tests required as we're just moving stuff from WebKit to
+ WebCore.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::defaultSession):
+
2012-02-16 Julien Chaffraix <jchaffr...@webkit.org>
thead in table without tbody causes table height doubling
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (107972 => 107973)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2012-02-16 20:56:02 UTC (rev 107973)
@@ -735,7 +735,10 @@
session = soup_session_async_new();
g_object_set(session,
SOUP_SESSION_MAX_CONNS, maxConnections,
- SOUP_SESSION_MAX_CONNS_PER_HOST, maxConnectionsPerHost,
+ SOUP_SESSION_MAX_CONNS_PER_HOST, maxConnectionsPerHost,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_CONTENT_DECODER,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_CONTENT_SNIFFER,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_PROXY_RESOLVER_DEFAULT,
NULL);
}
Modified: trunk/Source/WebKit/gtk/ChangeLog (107972 => 107973)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-02-16 20:56:02 UTC (rev 107973)
@@ -1,3 +1,20 @@
+2012-02-16 Sergio Villar Senin <svil...@igalia.com>
+
+ [soup] Move important SoupSession feature initialization to WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=68602
+
+ Reviewed by Martin Robinson.
+
+ Moved content sniffer and decoder initialization from WebKit to
+ WebCore because network stuff will not work as expected without
+ them.
+
+ No new tests required as we're just moving stuff from WebKit to
+ WebCore.
+
+ * webkit/webkitglobals.cpp:
+ (webkitInit):
+
2012-02-16 Philippe Normand <pnorm...@igalia.com>
Unreviewed, rolling out r107941.
Modified: trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp (107972 => 107973)
--- trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp 2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp 2012-02-16 20:56:02 UTC (rev 107973)
@@ -336,12 +336,6 @@
soup_session_add_feature(session, authDialog);
g_object_unref(authDialog);
- SoupSessionFeature* sniffer = static_cast<SoupSessionFeature*>(g_object_new(SOUP_TYPE_CONTENT_SNIFFER, NULL));
- soup_session_add_feature(session, sniffer);
- g_object_unref(sniffer);
-
- soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
-
#if USE(CLUTTER)
gtk_clutter_init(0, 0);
#endif
Modified: trunk/Source/WebKit2/ChangeLog (107972 => 107973)
--- trunk/Source/WebKit2/ChangeLog 2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-16 20:56:02 UTC (rev 107973)
@@ -1,3 +1,20 @@
+2012-02-16 Sergio Villar Senin <svil...@igalia.com>
+
+ [soup] Move important SoupSession feature initialization to WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=68602
+
+ Reviewed by Martin Robinson.
+
+ Moved content sniffer and decoder initialization from the
+ WebProcess to WebCore because network stuff will not work as
+ expected without them.
+
+ No new tests required as we're just moving stuff from the
+ WebProcess to WebCore.
+
+ * WebProcess/gtk/WebProcessMainGtk.cpp:
+ (WebKit::WebProcessMainGtk):
+
2012-02-16 Philippe Normand <pnorm...@igalia.com>
Unreviewed, rolling out r107941.
Modified: trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp (107972 => 107973)
--- trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp 2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp 2012-02-16 20:56:02 UTC (rev 107973)
@@ -60,8 +60,6 @@
RunLoop::initializeMainRunLoop();
SoupSession* session = WebCore::ResourceHandle::defaultSession();
- soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_SNIFFER);
- soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
soup_session_add_feature_by_type(session, WEB_TYPE_AUTH_DIALOG);
int socket = atoi(argv[1]);
