Title: [295699] trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
- Revision
- 295699
- Author
- pan...@apple.com
- Date
- 2022-06-21 16:22:07 -0700 (Tue, 21 Jun 2022)
Log Message
Web Inspector: Fonts details sidebar in Elements tab has empty space for filter bar
https://bugs.webkit.org/show_bug.cgi?id=241817
rdar://problem/95634156
Reviewed by Devin Rousso.
As pointed out by Devin, passing undefined to `toggle` here acts as if we didn't pass a value, not as a falsy value.
* Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype._showPanel):
Canonical link: https://commits.webkit.org/251703@main
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (295698 => 295699)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js 2022-06-21 23:21:07 UTC (rev 295698)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js 2022-06-21 23:22:07 UTC (rev 295699)
@@ -213,7 +213,7 @@
_showPanel()
{
this.contentView.addSubview(this._panel);
- this.contentView.element.classList.toggle("has-filter-bar", this._filterBar);
+ this.contentView.element.classList.toggle("has-filter-bar", !!this._filterBar);
if (this._filterBar)
this.contentView.element.classList.toggle(WI.GeneralStyleDetailsSidebarPanel.FilterInProgressClassName, this._filterBar.hasActiveFilters());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
