Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5d182d0202ae63407fec2fcb18bde76f269dc021
https://github.com/WebKit/WebKit/commit/5d182d0202ae63407fec2fcb18bde76f269dc021
Author: Aditya Keerthi <akeer...@apple.com>
Date: 2022-10-13 (Thu, 13 Oct 2022)
Changed paths:
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M
Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp
M
Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h
Log Message:
-----------
[media-controls] Duplicate buttons in top leading corner of fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=246414
rdar://100870340
Reviewed by Devin Rousso.
254333@main attempted to hide the hide the cancel and PiP buttons in fullscreen
if the current playback element already has those buttons. However, at the time
the `EnterFullScreen` message in sent to the UIProcess, the
`PlaybackSessionManager`
may not have a current playback element.
To fix, explicitly check if the element entering fullscreen is a `<video>` and
that it has controls. Additionally, rename `isVideoElement` to
`isVideoElementWithControls` for accuracy.
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::isVideoElementWithControls const):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::isVideoElement const): Deleted.
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):
*
Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
(WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
Canonical link: https://commits.webkit.org/255503@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
