Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 773a9ae47bff35f76ce9ea77c3ab34f7a68f4e6b https://github.com/WebKit/WebKit/commit/773a9ae47bff35f76ce9ea77c3ab34f7a68f4e6b Author: Darin Adler <da...@apple.com> Date: 2022-10-22 (Sat, 22 Oct 2022)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-shorthand-expected.txt M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h Log Message: ----------- font shorthand should reject out-of-range angles in for font-style https://bugs.webkit.org/show_bug.cgi?id=246572 rdar://problem/101437235 Reviewed by Tim Nguyen. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-shorthand-expected.txt: Expect some more PASS. * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeFontStyleKeywordValueRaw): Deleted. Not helpful to have this in a separate function. (WebCore::CSSPropertyParserHelpers::consumeFontStyleRaw): Fixed case where we would consume the keyword and angle if the angle failed to parse or if the angle parsed but was out of the allowed numeric range. This required a rollback to the position before the keyword. Also restructured the function so it's easier to read. * Source/WebCore/css/parser/CSSPropertyParserHelpers.h: Removed consumeFontStyleKeywordValueRaw. Canonical link: https://commits.webkit.org/255871@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes