Title: [108250] trunk/Source/WebKit2
Revision
108250
Author
carlo...@webkit.org
Date
2012-02-20 10:46:01 -0800 (Mon, 20 Feb 2012)

Log Message

[GTK] Adding SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature to soup session makes WebProcess to hang
https://bugs.webkit.org/show_bug.cgi?id=79036

Reviewed by Martin Robinson.

This looks like a bug in gobject. Initializing the WebProcess
before creating the soup session seems to fix the problem. It's
actually a workaround, but initializing the WebProcess as sson as
possible it's a good idea in any case.

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (108249 => 108250)


--- trunk/Source/WebKit2/ChangeLog	2012-02-20 18:35:12 UTC (rev 108249)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-20 18:46:01 UTC (rev 108250)
@@ -1,3 +1,18 @@
+2012-02-20  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Adding SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature to soup session makes WebProcess to hang
+        https://bugs.webkit.org/show_bug.cgi?id=79036
+
+        Reviewed by Martin Robinson.
+
+        This looks like a bug in gobject. Initializing the WebProcess
+        before creating the soup session seems to fix the problem. It's
+        actually a workaround, but initializing the WebProcess as sson as
+        possible it's a good idea in any case.
+
+        * WebProcess/gtk/WebProcessMainGtk.cpp:
+        (WebKit::WebProcessMainGtk):
+
 2012-02-20  Michael BrĂ¼ning  <michael.brun...@nokia.com>
 
         [Qt][WK2] Implement proxy authentication handling.

Modified: trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp (108249 => 108250)


--- trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp	2012-02-20 18:35:12 UTC (rev 108249)
+++ trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp	2012-02-20 18:46:01 UTC (rev 108250)
@@ -58,12 +58,12 @@
     WTF::initializeMainThread();
 
     RunLoop::initializeMainRunLoop();
+    int socket = atoi(argv[1]);
+    WebProcess::shared().initialize(socket, RunLoop::main());
+
     SoupSession* session = WebCore::ResourceHandle::defaultSession();
-
     soup_session_add_feature_by_type(session, WEB_TYPE_AUTH_DIALOG);
 
-    int socket = atoi(argv[1]);
-    WebProcess::shared().initialize(socket, RunLoop::main());
     RunLoop::run();
 
     return 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to