[webkit-changes] [WebKit/WebKit] 99cf25: Enable in vertical writing mode</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-changes@lists.webkit.org&q=from:%22Tim+Nguyen%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">Tim Nguyen</span></span></a></span> <span class="date"><a href="/search?l=webkit-changes@lists.webkit.org&q=date:20221123" rel="nofollow">Wed, 23 Nov 2022 10:46:03 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> Branch: refs/heads/main Home: <a rel="nofollow" href="https://github.com/WebKit/WebKit">https://github.com/WebKit/WebKit</a> Commit: 99cf25ddd405c557255c9ae6e865e7b922f8b145 <a rel="nofollow" href="https://github.com/WebKit/WebKit/commit/99cf25ddd405c557255c9ae6e865e7b922f8b145">https://github.com/WebKit/WebKit/commit/99cf25ddd405c557255c9ae6e865e7b922f8b145</a> Author: Tim Nguyen <n...@apple.com> Date: 2022-11-23 (Wed, 23 Nov 2022)</pre><pre> Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-slr.png A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-srl.png A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-vlr.png A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/vertical-form.png A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-horizontal.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-horizontal.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vlr.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vlr.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vrl.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vrl.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-horizontal.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-horizontal.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vlr.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vlr.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vrl.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vrl.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-rows-cols-sizing-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-rows-cols-sizing.html M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-slr.png R LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-srl.png R LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-vlr.png R LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/vertical-form.png M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/w3c-import.log M Source/WebCore/css/horizontalFormControls.css M Source/WebCore/css/html.css Log Message: ----------- Enable <textarea> in vertical writing mode <a rel="nofollow" href="https://bugs.webkit.org/show_bug.cgi?id=248260">https://bugs.webkit.org/show_bug.cgi?id=248260</a> rdar://102620075 Reviewed by Aditya Keerthi. It already works properly in vertical writing mode for the most part. Enable it behind the VerticalFormControlsEnabled setting. Upstream revision for WPT: <a rel="nofollow" href="https://github.com/web-platform-tests/wpt/commit/c758b0d0864c879ffe505c66ba6cf9345db0c665">https://github.com/web-platform-tests/wpt/commit/c758b0d0864c879ffe505c66ba6cf9345db0c665</a> * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-slr.png: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-slr.png. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-srl.png: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-srl.png. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-vlr.png: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-vlr.png. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/vertical-form.png: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/vertical-form.png. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-horizontal.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-horizontal.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vlr.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vlr.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vrl.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vrl.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-horizontal.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-horizontal.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vlr.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vlr.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vrl.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vrl.optional.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-rows-cols-sizing-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-rows-cols-sizing.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/w3c-import.log: * Source/WebCore/css/horizontalFormControls.css: (@namespace "<a rel="nofollow" href="http://www.w3.org/1999/xhtml"">http://www.w3.org/1999/xhtml"</a>;;): * Source/WebCore/css/html.css: (input:not([type="color"]), select, button, meter, progress): (input:not([type="color"]), textarea, select, button, meter, progress): Deleted. Canonical link: <a rel="nofollow" href="https://commits.webkit.org/256977@main">https://commits.webkit.org/256977@main</a> _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org <a rel="nofollow" href="https://lists.webkit.org/mailman/listinfo/webkit-changes">https://lists.webkit.org/mailman/listinfo/webkit-changes</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg191686.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#191687">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#191687">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg191688.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[webkit-changes] [WebKit/WebKit] 99cf25: Enable <textarea> in vertical writing mode"> <input type="hidden" name="msgid" value="WebKit/WebKit/push/refs/heads/main/85de8f-99cf25@github.com"> <input type="hidden" name="relpath" value="webkit-changes@lists.webkit.org/msg191687.html"> <input type="submit" value=" Tim Nguyen "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-changes@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-changes"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-changes@lists.webkit.org/">webkit-changes - all messages</a></li> <li class="icons-about"><a href="/webkit-changes@lists.webkit.org/info.html">webkit-changes - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-changes@lists.webkit.org&q=subject:%22%5C%5Bwebkit%5C-changes%5C%5D+%5C%5BWebKit%5C%2FWebKit%5C%5D+99cf25%5C%3A+Enable+%3Ctextarea%3E+in+vertical+writing+mode%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg191686.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg191688.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">WebKit/WebKit/push/refs/heads/main/85de8f-99cf25@github.com</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9e5bfa34fed1376a',t:'MTc3NTA5MjQ3Mw=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>