Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8d33356796453c7413c0a03a33139736bf5d4ca https://github.com/WebKit/WebKit/commit/e8d33356796453c7413c0a03a33139736bf5d4ca Author: Žan Doberšek <zdober...@igalia.com> Date: 2022-11-24 (Thu, 24 Nov 2022)
Changed paths: M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/NetworkProcess/NetworkResourceLoader.h M Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/SuspendedPageProxy.h M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebURLSchemeHandler.h M Source/WebKit/UIProcess/WebURLSchemeTask.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h M Source/WebKit/WebProcess/WebCoreSupport/WebNotificationClient.cpp M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Log Message: ----------- [WK2] Manually specify async-reply or delayed-reply CompletionHandler types https://bugs.webkit.org/show_bug.cgi?id=248274 Reviewed by Kimmo Kinnunen. Instead of the generated async-reply and delayed-reply CompletionHandler types and the type aliases placed on each message class, the desired CompletionHandler type should be manually specified for methods that have to operate with reply-expecting messages. The AsyncReply and DelayedReply types for relevant messages are right now generated in a separate header, to avoid including full message headers. The message classes then set up type aliases against those type definitions. But the reality is that these types are nowadays used in very few cases. Most often the CompletionHandler type is written out manually in the message-handling method declarations. This change applies the latter approach everywhere. One benefit of this is that it allows specifying the CompletionHandler in most optimal way, e.g. demanding rvalue references where beneficial. The default type definitions on the other hand enforce const lvalue references for objects of non-trivial types. Once these type definitions are removed from use, the separate headers can be dropped completely, along with a solid chuck of code covering message-related code generation. * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp: (WebKit::RemoteSourceBufferProxy::removeCodedFrames): (WebKit::RemoteSourceBufferProxy::evictCodedFrames): * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h: * Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h: * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::performSynchronousLoad): (WebKit::NetworkConnectionToWebProcess::testProcessIncomingSyncMessagesWhenWaitingForSyncReply): * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h: * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::SynchronousLoadData::SynchronousLoadData): (WebKit::sendReplyToSynchronousRequest): (WebKit::NetworkResourceLoader::NetworkResourceLoader): * Source/WebKit/NetworkProcess/NetworkResourceLoader.h: * Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h: * Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::WebPaymentCoordinatorProxy::getSetupFeatures): (WebKit::WebPaymentCoordinatorProxy::beginApplePaySetup): (WebKit::WebPaymentCoordinatorProxy::platformBeginApplePaySetup): * Source/WebKit/UIProcess/GPU/GPUProcessProxy.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::getNetworkProcessConnection): (WebKit::NetworkProcessProxy::testProcessIncomingSyncMessagesWhenWaitingForSyncReply): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp: * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionSync): * Source/WebKit/UIProcess/ProvisionalPageProxy.h: * Source/WebKit/UIProcess/SuspendedPageProxy.h: * Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp: (WebKit::WebUserContentControllerProxy::didPostMessage): * Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): (WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): (WebKit::WebPageProxy::getToolbarsAreVisible): (WebKit::WebPageProxy::getMenuBarIsVisible): (WebKit::WebPageProxy::getStatusBarIsVisible): (WebKit::WebPageProxy::getWindowFrame): (WebKit::WebPageProxy::screenToRootView): (WebKit::WebPageProxy::rootViewToScreen): (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): (WebKit::WebPageProxy::backForwardListCounts): (WebKit::WebPageProxy::exceededDatabaseQuota): (WebKit::WebPageProxy::reachedApplicationCacheOriginQuota): (WebKit::WebPageProxy::loadSynchronousURLSchemeTask): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getNetworkProcessConnection): * Source/WebKit/UIProcess/WebProcessProxy.h: * Source/WebKit/UIProcess/WebURLSchemeHandler.h: * Source/WebKit/UIProcess/WebURLSchemeTask.h: * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::getNetworkProcessConnection): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: * Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp: * Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp: * Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp: * Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h: * Source/WebKit/WebProcess/WebCoreSupport/WebNotificationClient.cpp: * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::testProcessIncomingSyncMessagesWhenWaitingForSyncReply): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::computePagesForPrintingiOS): (WebKit::WebPage::drawToPDFiOS): * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h: * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::requestRouteSharingPolicyAndContextUID): Canonical link: https://commits.webkit.org/256992@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes