Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (108403 => 108404)
--- trunk/Source/WebCore/CMakeLists.txt 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/CMakeLists.txt 2012-02-21 22:51:31 UTC (rev 108404)
@@ -2276,6 +2276,7 @@
)
SET(IDL_FILES_TMP ${DERIVED_SOURCES_WEBCORE_DIR}/idl_files.tmp)
SET(SUPPLEMENTAL_DEPENDENCY_FILE ${DERIVED_SOURCES_WEBCORE_DIR}/supplemental_dependency.tmp)
+SET(IDL_ATTRIBUTES_FILE ${WEBCORE_DIR}/bindings/scripts/IDLAttributes.txt)
INCLUDE(${WEBCORE_DIR}/UseJSC.cmake)
Modified: trunk/Source/WebCore/ChangeLog (108403 => 108404)
--- trunk/Source/WebCore/ChangeLog 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/ChangeLog 2012-02-21 22:51:31 UTC (rev 108404)
@@ -1,3 +1,28 @@
+2012-02-21 Kentaro Hara <hara...@chromium.org>
+
+ Enable the IDL attribute checker in all build systems
+ https://bugs.webkit.org/show_bug.cgi?id=79090
+
+ Reviewed by Adam Barth.
+
+ We have enabled the IDL attribute checker in Chromium in r108322.
+ This patch enables the IDL attribute checker in all other
+ build systems.
+
+ No tests. I manually checked that [Custommm], [CallWith=],
+ [CallWith=ScriptExecutionContext|Foo] cause build failures.
+
+ * CMakeLists.txt:
+ * DerivedSources.make:
+ * DerivedSources.pri:
+ * GNUmakefile.am:
+ * UseJSC.cmake:
+ * UseV8.cmake:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/scripts/IDLAttributes.txt: Added [ObjCCustomImplementation]
+ since I forgot to add it in r108322.
+
2012-02-21 Yael Aharon <yael.aha...@nokia.com>
[Texmap] Better management of shaders in TextureMapperGL
Modified: trunk/Source/WebCore/DerivedSources.make (108403 => 108404)
--- trunk/Source/WebCore/DerivedSources.make 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/DerivedSources.make 2012-02-21 22:51:31 UTC (rev 108404)
@@ -911,15 +911,16 @@
SUPPLEMENTAL_DEPENDENCY_FILE = ./supplemental_dependency.tmp
IDL_FILES_TMP = ./idl_files.tmp
ADDITIONAL_IDLS = $(WebCore)/inspector/_javascript_CallFrame.idl
+IDL_ATTRIBUTES_FILE = $(WebCore)/bindings/scripts/IDLAttributes.txt
# The following two lines get a space character stored in a variable.
# See <http://blog.jgc.org/2007/06/escaping-comma-and-space-in-gnu-make.html>.
space :=
space +=
-$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(RESOLVE_SUPPLEMENTAL_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS)
+$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(RESOLVE_SUPPLEMENTAL_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS) $(IDL_ATTRIBUTES_FILE)
printf "$(subst $(space),,$(patsubst %,%\n,$(BINDING_IDLS) $(ADDITIONAL_IDLS)))" > $(IDL_FILES_TMP)
- $(call resolve_supplemental_script, $(RESOLVE_SUPPLEMENTAL_SCRIPTS)) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@
+ $(call resolve_supplemental_script, $(RESOLVE_SUPPLEMENTAL_SCRIPTS)) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@ --idlAttributesFile $(IDL_ATTRIBUTES_FILE)
rm -f $(IDL_FILES_TMP)
JS%.h : %.idl $(JS_BINDINGS_SCRIPTS) $(SUPPLEMENTAL_DEPENDENCY_FILE)
Modified: trunk/Source/WebCore/DerivedSources.pri (108403 => 108404)
--- trunk/Source/WebCore/DerivedSources.pri 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/DerivedSources.pri 2012-02-21 22:51:31 UTC (rev 108404)
@@ -659,8 +659,9 @@
SUPPLEMENTAL_DEPENDENCY_FILE = supplemental_dependency.tmp
IDL_FILES_TMP = ${QMAKE_FUNC_FILE_OUT_PATH}/idl_files.tmp
RESOLVE_SUPPLEMENTAL_SCRIPT = $$PWD/bindings/scripts/resolve-supplemental.pl
+IDL_ATTRIBUTES_FILE = $$PWD/bindings/scripts/IDLAttributes.txt
-resolveSupplemental.input = RESOLVE_SUPPLEMENTAL_SCRIPT # dummy input to fire this rule
+resolveSupplemental.input = IDL_ATTRIBUTES_FILE
resolveSupplemental.script = $$RESOLVE_SUPPLEMENTAL_SCRIPT
# FIXME : We need to use only perl at some point.
resolveSupplemental.commands = echo $$IDL_BINDINGS | tr \' \' \'\\n\' > $$IDL_FILES_TMP && \
@@ -668,6 +669,7 @@
--defines \"$${FEATURE_DEFINES_JAVASCRIPT}\" \
--idlFilesList $$IDL_FILES_TMP \
--supplementalDependencyFile ${QMAKE_FUNC_FILE_OUT_PATH}/$$SUPPLEMENTAL_DEPENDENCY_FILE \
+ --idlAttributesFile $${IDL_ATTRIBUTES_FILE} \
--preprocessor \"$${QMAKE_MOC} -E\"
resolveSupplemental.output = $$SUPPLEMENTAL_DEPENDENCY_FILE
resolveSupplemental.add_output_to_sources = false
Modified: trunk/Source/WebCore/GNUmakefile.am (108403 => 108404)
--- trunk/Source/WebCore/GNUmakefile.am 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/GNUmakefile.am 2012-02-21 22:51:31 UTC (rev 108404)
@@ -789,13 +789,14 @@
SUPPLEMENTAL_DEPENDENCY_FILE = $(top_builddir)/DerivedSources/WebCore/supplemental_dependency.tmp
IDL_FILES_TMP = $(top_builddir)/DerivedSources/WebCore/idl_files.tmp
+IDL_ATTRIBUTES_FILE = $(WebCore)/bindings/scripts/IDLAttributes.txt
.SECONDARY:
-$(SUPPLEMENTAL_DEPENDENCY_FILE): $(SCRIPTS_FOR_RESOLVE_SUPPLEMENTAL) $(dom_binding_idls)
+$(SUPPLEMENTAL_DEPENDENCY_FILE): $(SCRIPTS_FOR_RESOLVE_SUPPLEMENTAL) $(dom_binding_idls) $(IDL_ATTRIBUTES_FILE)
$(AM_V_GEN)
$(AM_V_at)echo -n > $(IDL_FILES_TMP)
$(AM_V_at)($(foreach idl, $(dom_binding_idls), echo $(idl) &&) echo -n) >> $(IDL_FILES_TMP)
- $(AM_V_at)$(PERL) -I$(WebCore)/bindings/scripts $(WebCore)/bindings/scripts/resolve-supplemental.pl --defines "LANGUAGE_JAVASCRIPT=1 $(FEATURE_DEFINES)" --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@
+ $(AM_V_at)$(PERL) -I$(WebCore)/bindings/scripts $(WebCore)/bindings/scripts/resolve-supplemental.pl --defines "LANGUAGE_JAVASCRIPT=1 $(FEATURE_DEFINES)" --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@ --idlAttributesFile $(IDL_ATTRIBUTES_FILE)
.SECONDARY:
DerivedSources/WebCore/JS%.h: %.idl $(SCRIPTS_FOR_GENERATE_BINDINGS) $(WebCore)/bindings/scripts/CodeGeneratorJS.pm $(SUPPLEMENTAL_DEPENDENCY_FILE)
Modified: trunk/Source/WebCore/UseJSC.cmake (108403 => 108404)
--- trunk/Source/WebCore/UseJSC.cmake 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/UseJSC.cmake 2012-02-21 22:51:31 UTC (rev 108404)
@@ -267,8 +267,8 @@
ADD_CUSTOM_COMMAND(
OUTPUT ${SUPPLEMENTAL_DEPENDENCY_FILE}
- DEPENDS ${WEBCORE_DIR}/bindings/scripts/resolve-supplemental.pl ${SCRIPTS_RESOLVE_SUPPLEMENTAL} ${WebCore_IDL_FILES}
- COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/bindings/scripts/resolve-supplemental.pl --defines "${FEATURE_DEFINES_JAVASCRIPT}" --idlFilesList ${IDL_FILES_TMP} --preprocessor "${CODE_GENERATOR_PREPROCESSOR}" --supplementalDependencyFile ${SUPPLEMENTAL_DEPENDENCY_FILE}
+ DEPENDS ${WEBCORE_DIR}/bindings/scripts/resolve-supplemental.pl ${SCRIPTS_RESOLVE_SUPPLEMENTAL} ${WebCore_IDL_FILES} ${IDL_ATTRIBUTES_FILE}
+ COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/bindings/scripts/resolve-supplemental.pl --defines "${FEATURE_DEFINES_JAVASCRIPT}" --idlFilesList ${IDL_FILES_TMP} --preprocessor "${CODE_GENERATOR_PREPROCESSOR}" --supplementalDependencyFile ${SUPPLEMENTAL_DEPENDENCY_FILE} --idlAttributesFile ${IDL_ATTRIBUTES_FILE}
VERBATIM)
FOREACH (_file ${WebCore_IDL_FILES})
Modified: trunk/Source/WebCore/UseV8.cmake (108403 => 108404)
--- trunk/Source/WebCore/UseV8.cmake 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/UseV8.cmake 2012-02-21 22:51:31 UTC (rev 108404)
@@ -253,8 +253,8 @@
ADD_CUSTOM_COMMAND(
OUTPUT ${SUPPLEMENTAL_DEPENDENCY_FILE}
- DEPENDS ${WEBCORE_DIR}/bindings/scripts/resolve-supplemental.pl ${SCRIPTS_RESOLVE_SUPPLEMENTAL} ${WebCore_IDL_FILES}
- COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/bindings/scripts/resolve-supplemental.pl --defines "${FEATURE_DEFINES_JAVASCRIPT}" --idlFilesList ${IDL_FILES_TMP} --preprocessor "${CODE_GENERATOR_PREPROCESSOR}" --supplementalDependencyFile ${SUPPLEMENTAL_DEPENDENCY_FILE}
+ DEPENDS ${WEBCORE_DIR}/bindings/scripts/resolve-supplemental.pl ${SCRIPTS_RESOLVE_SUPPLEMENTAL} ${WebCore_IDL_FILES} ${IDL_ATTRIBUTES_FILE}
+ COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/bindings/scripts/resolve-supplemental.pl --defines "${FEATURE_DEFINES_JAVASCRIPT}" --idlFilesList ${IDL_FILES_TMP} --preprocessor "${CODE_GENERATOR_PREPROCESSOR}" --supplementalDependencyFile ${SUPPLEMENTAL_DEPENDENCY_FILE} --idlAttributesFile ${IDL_ATTRIBUTES_FILE}
VERBATIM)
FOREACH (_file ${WebCore_IDL_FILES})
Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (108403 => 108404)
--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2012-02-21 22:51:31 UTC (rev 108404)
@@ -68856,6 +68856,10 @@
RelativePath="..\bindings\scripts\resolve-supplemental.pl"
>
</File>
+ <File
+ RelativePath="..\bindings\scripts\IDLAttributes.txt"
+ >
+ </File>
</Filter>
</Filter>
<Filter
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (108403 => 108404)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-02-21 22:51:31 UTC (rev 108404)
@@ -10643,6 +10643,7 @@
A833C7F60A2CF1D800D57664 /* xmlattrs.in */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = text; path = xmlattrs.in; sourceTree = "<group>"; };
A833C80A0A2CF25600D57664 /* XMLNames.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = XMLNames.cpp; sourceTree = "<group>"; };
A833C80B0A2CF25600D57664 /* XMLNames.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = XMLNames.h; sourceTree = "<group>"; };
+ A83B533814F399BB00720D9D /* IDLAttributes.txt */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = IDLAttributes.txt; path = scripts/IDLAttributes.txt; sourceTree = "<group>"; };
A83B78F20CCAFF15000B0825 /* JSSVGFontFaceUriElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSSVGFontFaceUriElement.h; sourceTree = "<group>"; };
A83B78F30CCAFF15000B0825 /* JSSVGFontFaceUriElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSSVGFontFaceUriElement.cpp; sourceTree = "<group>"; };
A83B78F40CCAFF15000B0825 /* JSSVGFontFaceSrcElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSSVGFontFaceSrcElement.h; sourceTree = "<group>"; };
@@ -19182,6 +19183,7 @@
BC1A3790097C6F970019F3D8 /* bindings */ = {
isa = PBXGroup;
children = (
+ A83B533814F399BB00720D9D /* IDLAttributes.txt */,
B5D31DF711CF60E5009F22B4 /* generic */,
BC1A3793097C6FB10019F3D8 /* js */,
BC1A3794097C6FC40019F3D8 /* objc */,
Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (108403 => 108404)
--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2012-02-21 22:46:01 UTC (rev 108403)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2012-02-21 22:51:31 UTC (rev 108404)
@@ -82,6 +82,7 @@
NamedGetter
NotEnumerable
NumericIndexedGetter
+ObjCCustomImplementation
ObjCLegacyUnnamedParameters
ObjCPolymorphic
ObjCProtocol
