Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 03d50508e4139e54f59354d08552b4f2e95831c4 https://github.com/WebKit/WebKit/commit/03d50508e4139e54f59354d08552b4f2e95831c4 Author: Sihui Liu <sihui_...@apple.com> Date: 2022-12-20 (Tue, 20 Dec 2022)
Changed paths: M Source/WebCore/Modules/cookie-consent/NavigatorCookieConsent.cpp M Source/WebCore/Modules/cookie-consent/NavigatorCookieConsent.h M Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.h Log Message: ----------- Do not use std::optional for optional dictionary parameters https://bugs.webkit.org/show_bug.cgi?id=249639 rdar://103549528 Reviewed by Chris Dumez. In our current implementation, generated code will always create a dictionary (struct) and pass it as parameter, so the parameter will never be std::nullopt. * Source/WebCore/Modules/cookie-consent/NavigatorCookieConsent.cpp: (WebCore::NavigatorCookieConsent::requestCookieConsent): * Source/WebCore/Modules/cookie-consent/NavigatorCookieConsent.h: * Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp: (WebCore::FileSystemDirectoryHandle::getFileHandle): (WebCore::FileSystemDirectoryHandle::getDirectoryHandle): (WebCore::FileSystemDirectoryHandle::removeEntry): * Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.h: Canonical link: https://commits.webkit.org/258140@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes