Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f0ccda887910822ac9532cc9c50f9953be91d89 https://github.com/WebKit/WebKit/commit/4f0ccda887910822ac9532cc9c50f9953be91d89 Author: Antti Koivisto <an...@apple.com> Date: 2022-12-22 (Thu, 22 Dec 2022)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom.html M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-shadow-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-shadow.html M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/determine-registration-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/determine-registration.html M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom.html M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties.html M Source/WebCore/css/CSSProperty.h M Source/WebCore/css/CSSPropertyRule.cpp M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/process-css-properties.py Log Message: ----------- [@property] Whitespaces around initial-value should be trimmed https://bugs.webkit.org/show_bug.cgi?id=249770 <rdar://problem/103636334> Reviewed by Tim Nguyen. Partially revert https://commits.webkit.org/258215@main. It turns out that WebKit whitespace handling for custom properties (where whitespace is always trimmed) is correct per https://drafts.csswg.org/css-syntax-3/#consume-declaration and this applies to the `initial-value` property too. This is tested by imported/w3c/web-platform-tests/css/css-syntax/declarations-trim-whitespace.html which we pass and other engines fail. Update the @property tests to the spec. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-shadow-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-shadow.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/determine-registration-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/determine-registration.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties.html: * Source/WebCore/css/CSSPropertyRule.cpp: (WebCore::CSSPropertyRule::cssText const): * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeDeclaration): * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseValue): * Source/WebCore/css/process-css-properties.py: (PropertiesAndDescriptors.all_descriptor_only): (Grammar.perform_fixups_for_values_references): (GenerateCSSPropertyNames): (PropertiesAndDescriptors.all_preserving_whitespace): Deleted. (Grammar.preserve_whitespace): Deleted. Canonical link: https://commits.webkit.org/258245@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes