Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab6bfa2b75b51921f2160af4cc66bace51d82849 https://github.com/WebKit/WebKit/commit/ab6bfa2b75b51921f2160af4cc66bace51d82849 Author: David Kilzer <ddkil...@apple.com> Date: 2023-01-09 (Mon, 09 Jan 2023)
Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/API/Cocoa/_WKSameDocumentNavigationTypeInternal.h M Source/WebKit/Shared/API/c/WKSharedAPICast.h M Source/WebKit/Shared/SameDocumentNavigationType.h A Source/WebKit/Shared/SameDocumentNavigationType.serialization.in M Source/WebKit/UIProcess/API/APILoaderClient.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h M Source/WebKit/UIProcess/ViewGestureController.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Log Message: ----------- WebKit::WebPageProxy::didSameDocumentNavigationForFrame[ViaJSHistoryAPI]() should take a WebKit::SameDocumentNavigationType https://bugs.webkit.org/show_bug.cgi?id=250304 <rdar://65495222> Reviewed by Youenn Fablet. Update WebPageProxy::didSameDocumentNavigationForFrame() and WebPageProxy::didSameDocumentNavigationForFrameViaJSHistoryAPI() to use the enum class SameDocumentNavigationType instead of uint32_t. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: - Update build files to add SameDocumentNavigationType.serialization.in. * Source/WebKit/Shared/API/Cocoa/_WKSameDocumentNavigationTypeInternal.h: (WebKit::toWKSameDocumentNavigationType): * Source/WebKit/Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toSameDocumentNavigationType): (WebKit::toDiagnosticLoggingResultType): - Add ASSERT_NOT_REACHED() after switch statements that should never fall through. Switch to use early return statements. * Source/WebKit/Shared/SameDocumentNavigationType.h: - Switch to "#pramga once". - Make SameDocumentNavigationType an enum class. * Source/WebKit/Shared/SameDocumentNavigationType.serialization.in: Add. - Used for IPC encoding/decoding. * Source/WebKit/UIProcess/API/APILoaderClient.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: - Remove unneeded header include of "SameDocumentNavigationType.h". * Source/WebKit/UIProcess/ViewGestureController.cpp: (WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): (WebKit::WebPageProxy::didSameDocumentNavigationForFrameViaJSHistoryAPI): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::WebFrameLoaderClient::didSameDocumentNavigationForFrameViaJSHistoryAPI): (WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage): Canonical link: https://commits.webkit.org/258676@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes