Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46a7fc2a36c0040d3ad591a8405ef0c3d0214b5d https://github.com/WebKit/WebKit/commit/46a7fc2a36c0040d3ad591a8405ef0c3d0214b5d Author: Žan Doberšek <zdober...@igalia.com> Date: 2023-02-11 (Sat, 11 Feb 2023)
Changed paths: M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp M Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSExposedStar.cpp M Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp M Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSShadowRealmGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncIterable.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncKeyValueIterable.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestConditionalIncludes.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDomainSecurity.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledForContext.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestIterable.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestMapLike.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestOperationConditional.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestSetLike.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStringifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestTaggedWrapper.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp M Source/WebCore/bindings/scripts/test/JS/JSWorkerGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSWorkletGlobalScope.cpp Log Message: ----------- CodeGeneratorJS: use ASCIILiteral when constructing URL string for the HeapAnalyzer::setLabelForCell() call https://bugs.webkit.org/show_bug.cgi?id=251982 Reviewed by Darin Adler. The URL string construction done for the HeapAnalyzer::setLabelForCell() call should use an ASCIILiteral in the operator+ invocation, instead of a native C string literal. Test baselines for JS code generation are updated accordingly. * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): * Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp: (WebCore::JSDOMWindow::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp: (WebCore::JSDedicatedWorkerGlobalScope::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSExposedStar.cpp: (WebCore::JSExposedStar::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp: (WebCore::JSExposedToWorkerAndWindow::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp: (WebCore::JSPaintWorkletGlobalScope::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp: (WebCore::JSServiceWorkerGlobalScope::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSShadowRealmGlobalScope.cpp: (WebCore::JSShadowRealmGlobalScope::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.cpp: (WebCore::JSSharedWorkerGlobalScope::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestAsyncIterable.cpp: (WebCore::JSTestAsyncIterable::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestAsyncKeyValueIterable.cpp: (WebCore::JSTestAsyncKeyValueIterable::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp: (WebCore::JSTestCEReactions::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp: (WebCore::JSTestCEReactionsStringifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.cpp: (WebCore::JSTestCallTracer::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp: (WebCore::JSTestClassWithJSBuiltinConstructor::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestConditionalIncludes.cpp: (WebCore::JSTestConditionalIncludes::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp: (WebCore::JSTestConditionallyReadWrite::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp: (WebCore::JSTestDOMJIT::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.cpp: (WebCore::JSTestDefaultToJSON::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp: (WebCore::JSTestDefaultToJSONFilteredByExposed::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp: (WebCore::JSTestDefaultToJSONIndirectInheritance::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp: (WebCore::JSTestDefaultToJSONInherit::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp: (WebCore::JSTestDefaultToJSONInheritFinal::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.cpp: (WebCore::JSTestDelegateToSharedSyntheticAttribute::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestDomainSecurity.cpp: (WebCore::JSTestDomainSecurity::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp: (WebCore::JSTestEnabledBySetting::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestEnabledForContext.cpp: (WebCore::JSTestEnabledForContext::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp: (WebCore::JSTestEventConstructor::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp: (WebCore::JSTestEventTarget::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp: (WebCore::JSTestException::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp: (WebCore::JSTestGenerateAddOpaqueRoot::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: (WebCore::JSTestGenerateIsReachable::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp: (WebCore::JSTestGlobalObject::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp: (WebCore::JSTestIndexedSetterNoIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp: (WebCore::JSTestIndexedSetterThrowingException::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp: (WebCore::JSTestIndexedSetterWithIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterface::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp: (WebCore::JSTestInterfaceLeadingUnderscore::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestIterable.cpp: (WebCore::JSTestIterable::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp: (WebCore::JSTestLegacyFactoryFunction::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp: (WebCore::JSTestLegacyNoInterfaceObject::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp: (WebCore::JSTestLegacyOverrideBuiltIns::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestMapLike.cpp: (WebCore::JSTestMapLike::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp: (WebCore::JSTestMapLikeWithOverriddenOperations::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp: (WebCore::JSTestNamedAndIndexedSetterNoIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp: (WebCore::JSTestNamedAndIndexedSetterThrowingException::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp: (WebCore::JSTestNamedAndIndexedSetterWithIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp: (WebCore::JSTestNamedDeleterNoIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp: (WebCore::JSTestNamedDeleterThrowingException::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp: (WebCore::JSTestNamedDeleterWithIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp: (WebCore::JSTestNamedDeleterWithIndexedGetter::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp: (WebCore::JSTestNamedGetterCallWith::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp: (WebCore::JSTestNamedGetterNoIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp: (WebCore::JSTestNamedGetterWithIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp: (WebCore::JSTestNamedSetterNoIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp: (WebCore::JSTestNamedSetterThrowingException::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp: (WebCore::JSTestNamedSetterWithIdentifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp: (WebCore::JSTestNamedSetterWithIndexedGetter::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp: (WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp: (WebCore::JSTestNamedSetterWithLegacyOverrideBuiltIns::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp: (WebCore::JSTestNamedSetterWithLegacyUnforgeableProperties::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp: (WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp: (WebCore::JSTestNode::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObj::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestOperationConditional.cpp: (WebCore::JSTestOperationConditional::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: (WebCore::JSTestOverloadedConstructors::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp: (WebCore::JSTestOverloadedConstructorsWithSequence::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.cpp: (WebCore::JSTestPluginInterface::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp: (WebCore::JSTestPromiseRejectionEvent::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp: (WebCore::JSTestReadOnlyMapLike::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp: (WebCore::JSTestReadOnlySetLike::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp: (WebCore::JSTestReportExtraMemoryCost::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::JSTestSerializedScriptValueInterface::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestSetLike.cpp: (WebCore::JSTestSetLike::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp: (WebCore::JSTestSetLikeWithOverriddenOperations::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestStringifier.cpp: (WebCore::JSTestStringifier::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp: (WebCore::JSTestStringifierAnonymousOperation::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp: (WebCore::JSTestStringifierNamedOperation::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp: (WebCore::JSTestStringifierOperationImplementedAs::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp: (WebCore::JSTestStringifierOperationNamedToString::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp: (WebCore::JSTestStringifierReadOnlyAttribute::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp: (WebCore::JSTestStringifierReadWriteAttribute::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestTaggedWrapper.cpp: (WebCore::JSTestTaggedWrapper::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp: (WebCore::JSTestTypedefs::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSWorkerGlobalScope.cpp: (WebCore::JSWorkerGlobalScope::analyzeHeap): * Source/WebCore/bindings/scripts/test/JS/JSWorkletGlobalScope.cpp: (WebCore::JSWorkletGlobalScope::analyzeHeap): Canonical link: https://commits.webkit.org/260151@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes