Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 68ae85e5b18813ea881d0f18312e848a9389366e
https://github.com/WebKit/WebKit/commit/68ae85e5b18813ea881d0f18312e848a9389366e
Author: Aditya Keerthi <akeer...@apple.com>
Date: 2023-02-23 (Thu, 23 Feb 2023)
Changed paths:
M Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/RenderThemeCocoa.h
M Source/WebCore/rendering/RenderThemeCocoa.mm
M Source/WebCore/rendering/RenderThemeMac.h
M Source/WebCore/rendering/RenderThemeMac.mm
Log Message:
-----------
Add support for painting document markers using system colors
https://bugs.webkit.org/show_bug.cgi?id=252791
rdar://105796291
Reviewed by Wenson Hsieh and Megan Gardner.
Use system colors for painting document markers when possible. To support this
functionality, new `RenderTheme` methods are added to control platform-specific
marker colors and the color cache is expanded for the new colors. This approach
matches the implementation of existing system colors.
* Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::spellingMarkerColor const):
(WebCore::RenderTheme::platformSpellingMarkerColor const):
(WebCore::RenderTheme::dictationAlternativesMarkerColor const):
(WebCore::RenderTheme::platformDictationAlternativesMarkerColor const):
(WebCore::RenderTheme::autocorrectionReplacementMarkerColor const):
(WebCore::RenderTheme::platformAutocorrectionReplacementMarkerColor const):
(WebCore::RenderTheme::grammarMarkerColor const):
(WebCore::RenderTheme::platformGrammarMarkerColor const):
(WebCore::RenderTheme::documentMarkerLineColor const):
* Source/WebCore/rendering/RenderTheme.h:
* Source/WebCore/rendering/RenderThemeCocoa.h:
* Source/WebCore/rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::platformSpellingMarkerColor const):
(WebCore::RenderThemeCocoa::platformDictationAlternativesMarkerColor const):
(WebCore::RenderThemeCocoa::platformAutocorrectionReplacementMarkerColor const):
(WebCore::RenderThemeCocoa::platformGrammarMarkerColor const):
(WebCore::grammarColor): Deleted.
(WebCore::RenderThemeCocoa::documentMarkerLineColor const): Deleted.
* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::usePlatformColorForAutocorrectionReplacementMarker):
(WebCore::RenderThemeMac::platformAutocorrectionReplacementMarkerColor const):
Canonical link: https://commits.webkit.org/260779@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
