Title: [108762] trunk/LayoutTests
- Revision
- 108762
- Author
- commit-qu...@webkit.org
- Date
- 2012-02-24 02:40:38 -0800 (Fri, 24 Feb 2012)
Log Message
[Chromium] video-referer.html fails
https://bugs.webkit.org/show_bug.cgi?id=79239
Fix error event race at startup and cleanup event code to take
advantage of more succinct video-test.js functionality; such as
waitForEventAndFail, etc.
Since this test uses a <source> element without a 'src' tag, an error
event gets fired during load. If we don't wait until after the <body>
onload fires, we'll pickup this error we don't care about.
Patch by Dale Curtis <dalecur...@chromium.org> on 2012-02-24
Reviewed by Eric Carlson.
* http/tests/media/video-referer-expected.txt:
* http/tests/media/video-referer.html:
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (108761 => 108762)
--- trunk/LayoutTests/ChangeLog 2012-02-24 10:33:48 UTC (rev 108761)
+++ trunk/LayoutTests/ChangeLog 2012-02-24 10:40:38 UTC (rev 108762)
@@ -1,3 +1,22 @@
+2012-02-24 Dale Curtis <dalecur...@chromium.org>
+
+ [Chromium] video-referer.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=79239
+
+ Fix error event race at startup and cleanup event code to take
+ advantage of more succinct video-test.js functionality; such as
+ waitForEventAndFail, etc.
+
+ Since this test uses a <source> element without a 'src' tag, an error
+ event gets fired during load. If we don't wait until after the <body>
+ onload fires, we'll pickup this error we don't care about.
+
+ Reviewed by Eric Carlson.
+
+ * http/tests/media/video-referer-expected.txt:
+ * http/tests/media/video-referer.html:
+ * platform/chromium/test_expectations.txt:
+
2012-02-24 Nikolas Zimmermann <nzimmerm...@rim.com>
Not reviewed. Update layout test results after r108699.
Modified: trunk/LayoutTests/http/tests/media/video-referer-expected.txt (108761 => 108762)
--- trunk/LayoutTests/http/tests/media/video-referer-expected.txt 2012-02-24 10:33:48 UTC (rev 108761)
+++ trunk/LayoutTests/http/tests/media/video-referer-expected.txt 2012-02-24 10:40:38 UTC (rev 108762)
@@ -1,3 +1,4 @@
EVENT(canplay)
+END OF TEST
Tests that the media player will send the relevant referer when requesting the media file.
Modified: trunk/LayoutTests/http/tests/media/video-referer.html (108761 => 108762)
--- trunk/LayoutTests/http/tests/media/video-referer.html 2012-02-24 10:33:48 UTC (rev 108761)
+++ trunk/LayoutTests/http/tests/media/video-referer.html 2012-02-24 10:40:38 UTC (rev 108762)
@@ -14,26 +14,19 @@
var frame = document.createElement('iframe');
frame.width = 0;
frame.height = 0;
- frame.src = ""
frame.addEventListener('load', function () {
- video = document.getElementById('video');
source = document.getElementById('source');
source.src = '' + movie + '&type=' + type;
source.type = type;
+
+ waitForEventAndFail('error');
+ waitForEventAndEnd('canplay');
video.load();
});
+ frame.src = ""
document.body.appendChild(frame);
}
-
- waitForEventAndEnd('error', function () {
- consoleWrite('FAIL, got error when loading media error: ' + video.error.code);
- });
-
- waitForEvent('canplay', function () {
- if (window.layoutTestController)
- window.layoutTestController.notifyDone();
- } );
</script>
Tests that the media player will send the relevant referer when requesting the media file.<br/>
</body>
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (108761 => 108762)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-24 10:33:48 UTC (rev 108761)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-24 10:40:38 UTC (rev 108762)
@@ -4202,9 +4202,6 @@
BUGWK79224 VISTA WIN7 : fast/canvas/webgl/tex-image-with-format-and-type.html = TEXT
-// Failing after test was updated in r108387, media engine sending incorrect referrer?
-BUGWK79239 : http/tests/media/video-referer.html = FAIL
-
// Need rebaselining after bug 75091
BUGWK75091 SKIP : svg/carto.net/tabgroup.svg = FAIL
BUGWK75091 SKIP : svg/carto.net/window.svg = FAIL
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
