Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e5975bd98661d2dc24e807170ca625bacbbc498b
https://github.com/WebKit/WebKit/commit/e5975bd98661d2dc24e807170ca625bacbbc498b
Author: Philippe Normand <ph...@igalia.com>
Date: 2023-04-11 (Tue, 11 Apr 2023)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
A
LayoutTests/platform/glib/fast/mediastream/getDisplayMedia-size-expected.txt
M
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp
M
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h
M Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
M Source/WebCore/platform/mock/MockRealtimeVideoSource.h
Log Message:
-----------
[GStreamer] test fast/mediastream/getDisplayMedia-size.html fails
https://bugs.webkit.org/show_bug.cgi?id=233731
Reviewed by Xabier Rodriguez-Calvar.
The main fix here is to wrap the MockDisplayCaptureSourceGStreamer in a
RealtimeVideoSource, same
logic as the MockRealtimeVideoSourceGStreamer.
This patch also fixes fast/mediastream/getDisplayMedia-displaySurface.html by
adjusting the source
settings displaySurface, depending on which surface we're behaving as. The
non-mock GStreamer
DisplayCapture source will need to set this setting too, but that's going to be
addressed in a
follow-up patch.
* LayoutTests/platform/glib/TestExpectations:
*
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
(WebCore::MockDisplayCaptureSourceGStreamer::create):
(WebCore::MockDisplayCaptureSourceGStreamer::MockDisplayCaptureSourceGStreamer):
(WebCore::MockDisplayCaptureSourceGStreamer::settings):
*
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h:
* Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:
* Source/WebCore/platform/mock/MockRealtimeVideoSource.h:
Canonical link: https://commits.webkit.org/262825@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
