- Revision
- 109031
- Author
- k...@profusion.mobi
- Date
- 2012-02-27 15:40:12 -0800 (Mon, 27 Feb 2012)
Log Message
[BlackBerry][EFL] Provide dummy RunLoop implementations.
https://bugs.webkit.org/show_bug.cgi?id=79398
Reviewed by Antonio Gomes.
r108067 fixed the EFL build by not building RunLoop.cpp on EFL and
BlackBerry, as both platforms lack an implementation that provides the
missing methods for the RunLoop class.
However, RunLoop.cpp is a generic file which should not be included
directly in PlatformWinCE.cmake (plus it helps in converting the
AppleWin port to CMake).
Fix this by providing a dummy implementation of the missing RunLoop
methods for both EFL and BlackBerry.
* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:
* platform/blackberry/RunLoopBlackBerry.cpp: Added.
(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):
* platform/efl/RunLoopEfl.cpp: Added.
(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):
Modified Paths
Added Paths
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (109030 => 109031)
--- trunk/Source/WebCore/CMakeLists.txt 2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/CMakeLists.txt 2012-02-27 23:40:12 UTC (rev 109031)
@@ -1094,6 +1094,7 @@
platform/MIMETypeRegistry.cpp
platform/MemoryPressureHandler.cpp
platform/PlatformEvent.cpp
+ platform/RunLoop.cpp
platform/RuntimeApplicationChecks.cpp
platform/ScrollAnimator.cpp
platform/ScrollableArea.cpp
Modified: trunk/Source/WebCore/ChangeLog (109030 => 109031)
--- trunk/Source/WebCore/ChangeLog 2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/ChangeLog 2012-02-27 23:40:12 UTC (rev 109031)
@@ -1,3 +1,36 @@
+2012-02-23 Raphael Kubo da Costa <k...@profusion.mobi>
+
+ [BlackBerry][EFL] Provide dummy RunLoop implementations.
+ https://bugs.webkit.org/show_bug.cgi?id=79398
+
+ Reviewed by Antonio Gomes.
+
+ r108067 fixed the EFL build by not building RunLoop.cpp on EFL and
+ BlackBerry, as both platforms lack an implementation that provides the
+ missing methods for the RunLoop class.
+
+ However, RunLoop.cpp is a generic file which should not be included
+ directly in PlatformWinCE.cmake (plus it helps in converting the
+ AppleWin port to CMake).
+
+ Fix this by providing a dummy implementation of the missing RunLoop
+ methods for both EFL and BlackBerry.
+
+ * CMakeLists.txt:
+ * PlatformBlackBerry.cmake:
+ * PlatformEfl.cmake:
+ * PlatformWinCE.cmake:
+ * platform/blackberry/RunLoopBlackBerry.cpp: Added.
+ (WebCore):
+ (WebCore::RunLoop::RunLoop):
+ (WebCore::RunLoop::~RunLoop):
+ (WebCore::RunLoop::wakeUp):
+ * platform/efl/RunLoopEfl.cpp: Added.
+ (WebCore):
+ (WebCore::RunLoop::RunLoop):
+ (WebCore::RunLoop::~RunLoop):
+ (WebCore::RunLoop::wakeUp):
+
2012-02-27 John Sullivan <sulli...@apple.com>
Build fix (on Lion at least).
Modified: trunk/Source/WebCore/PlatformBlackBerry.cmake (109030 => 109031)
--- trunk/Source/WebCore/PlatformBlackBerry.cmake 2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/PlatformBlackBerry.cmake 2012-02-27 23:40:12 UTC (rev 109031)
@@ -153,6 +153,7 @@
platform/blackberry/PlatformTouchPointBlackBerry.cpp
platform/blackberry/PopupMenuBlackBerry.cpp
platform/blackberry/RenderThemeBlackBerry.cpp
+ platform/blackberry/RunLoopBlackBerry.cpp
platform/blackberry/SSLKeyGeneratorBlackBerry.cpp
platform/blackberry/ScrollbarThemeBlackBerry.cpp
platform/blackberry/SearchPopupMenuBlackBerry.cpp
Modified: trunk/Source/WebCore/PlatformEfl.cmake (109030 => 109031)
--- trunk/Source/WebCore/PlatformEfl.cmake 2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/PlatformEfl.cmake 2012-02-27 23:40:12 UTC (rev 109031)
@@ -47,6 +47,7 @@
platform/efl/PopupMenuEfl.cpp
platform/efl/RefPtrEfl.cpp
platform/efl/RenderThemeEfl.cpp
+ platform/efl/RunLoopEfl.cpp
platform/efl/ScrollViewEfl.cpp
platform/efl/ScrollbarEfl.cpp
platform/efl/ScrollbarThemeEfl.cpp
Modified: trunk/Source/WebCore/PlatformWinCE.cmake (109030 => 109031)
--- trunk/Source/WebCore/PlatformWinCE.cmake 2012-02-27 23:32:01 UTC (rev 109030)
+++ trunk/Source/WebCore/PlatformWinCE.cmake 2012-02-27 23:40:12 UTC (rev 109031)
@@ -32,7 +32,6 @@
platform/Cursor.cpp
platform/LocalizedStrings.cpp
platform/PlatformStrategies.cpp
- platform/RunLoop.cpp
platform/ScrollAnimatorWin.cpp
platform/graphics/ImageSource.cpp
Added: trunk/Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp (0 => 109031)
--- trunk/Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp (rev 0)
+++ trunk/Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp 2012-02-27 23:40:12 UTC (rev 109031)
@@ -0,0 +1,48 @@
+/*
+ * Copyright (C) 2012 ProFUSION embedded systems. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "RunLoop.h"
+
+#include "NotImplemented.h"
+
+namespace WebCore {
+
+RunLoop::RunLoop()
+{
+ notImplemented();
+}
+
+RunLoop::~RunLoop()
+{
+ notImplemented();
+}
+
+void RunLoop::wakeUp()
+{
+ notImplemented();
+}
+
+} // namespace WebCore
Added: trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp (0 => 109031)
--- trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp (rev 0)
+++ trunk/Source/WebCore/platform/efl/RunLoopEfl.cpp 2012-02-27 23:40:12 UTC (rev 109031)
@@ -0,0 +1,48 @@
+/*
+ * Copyright (C) 2012 ProFUSION embedded systems. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "RunLoop.h"
+
+#include "NotImplemented.h"
+
+namespace WebCore {
+
+RunLoop::RunLoop()
+{
+ notImplemented();
+}
+
+RunLoop::~RunLoop()
+{
+ notImplemented();
+}
+
+void RunLoop::wakeUp()
+{
+ notImplemented();
+}
+
+} // namespace WebCore
